Skip to content

N14: Updates to space_shooter_rs game #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2020
Merged

N14: Updates to space_shooter_rs game #298

merged 2 commits into from
Oct 5, 2020

Conversation

tigleym
Copy link
Contributor

@tigleym tigleym commented Oct 4, 2020

Part of #278 (Newsletter 14)

@tigleym tigleym changed the title N14: Updates space_shooter_rs game N14: Updates to space_shooter_rs game Oct 4, 2020
@ozkriff ozkriff mentioned this pull request Oct 4, 2020
Closed
49 tasks
17cupsofcoffee
17cupsofcoffee approved these changes Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

ozkriff
ozkriff requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for the GIF size - we're usually trying to keep gifs under 2 or 3 MBs. 13MB is certainly too big - could you trim it down, please?

@tigleym
Copy link
Contributor Author

tigleym commented Oct 5, 2020

13MB is certainly too big - could you trim it down, please?

Sure thing! 👍

@tigleym tigleym force-pushed the space_shooter_rs_section branch from 4826d13 to 7c88e7e Compare October 5, 2020 18:42
ozkriff
ozkriff approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾

@ozkriff ozkriff merged commit 2a8ed80 into rust-gamedev:source Oct 5, 2020
@ozkriff
Copy link
Member

ozkriff commented Oct 5, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigleym @ozkriff @17cupsofcoffee