Skip to content

N26: godot-rust #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2021
Merged

N26: godot-rust #789

merged 1 commit into from
Oct 3, 2021

Conversation

Bromeon
Copy link
Contributor

@Bromeon Bromeon commented Oct 2, 2021

Part of #783

@ozkriff ozkriff mentioned this pull request Oct 3, 2021
Closed
50 tasks
ozkriff
ozkriff requested changes Oct 3, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md:

Write in third-person perspective.

Could you convert the section to the third-person perspective and remove the closing "_Discussions" sentence that doesn't have real links, please?

@Bromeon Bromeon force-pushed the source branch 3 times, most recently from e192ca6 to 810efe6 Compare October 3, 2021 15:02
@Bromeon
Copy link
Contributor Author

Bromeon commented Oct 3, 2021

Thanks for the feedback! I updated it accordingly 👍🏼

@ozkriff ozkriff merged commit 6a84be6 into rust-gamedev:source Oct 3, 2021
@ozkriff
Copy link
Member

ozkriff commented Oct 3, 2021

Great, merged! Congrats on the first newsletter PR! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bromeon @ozkriff