Skip to content

Rename poll_complete to poll_flush #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aturon opened this issue Jan 31, 2017 · 2 comments
Closed

Rename poll_complete to poll_flush #379

aturon opened this issue Jan 31, 2017 · 2 comments

Comments

@aturon
Copy link
Member

aturon commented Jan 31, 2017

Clarify the semantics of poll_complete by renaming to poll_flush.
@aturon aturon added this to the 0.2 release milestone Jan 31, 2017
@aturon aturon mentioned this issue Jan 31, 2017
Closed
@alexcrichton
Copy link
Member

With Sink::close we may also wish to consider Sink::flush instead of Sink::poll_flush

alexcrichton added a commit that referenced this issue Mar 7, 2017
@alexcrichton
Update Sink::poll_complete docs
343a553 
This commit updates the documentation on `Sink::poll_complete` in light of #379
where it is our intention to eventually rename this method to `poll_flush`.
Additionally this method is now (and always has been) simply responsible for
flushing values from a sink.

The documentation has been updated to reflect all these aspects.
@alexcrichton alexcrichton mentioned this issue Mar 7, 2017
Merged
alexcrichton added a commit that referenced this issue Feb 9, 2018
@alexcrichton
Rename Sink::poll_complete to flush
9ca313a 
Along with a few other changes:

* Move the `Sink::flush` combinator to a free `flush` function
* Add a free `close` combinator

Closes #379
@alexcrichton alexcrichton mentioned this issue Feb 9, 2018
Merged
@alexcrichton
Copy link
Member

Fixed in #747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @aturon