Rename Sink::poll_complete to flush
#747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with a few other changes: * Move the `Sink::flush` combinator to a free `flush` function * Add a free `close` combinator Closes #379
ahmedcharles
approved these changes
Feb 9, 2018
| /// Get a shared reference to the inner sink. | ||
| /// Returns `None` if the sink has already been closeed. | ||
| pub fn get_ref(&self) -> Option<&S> { | ||
| self.sink.as_ref() |
There was a problem hiding this comment.
Some combinators return &S here instead and panic when sink is None. Is there a reason why there are two patterns?
There was a problem hiding this comment.
All of the as_ref/get_ref/get_mut style combinators return Option. Future implementations panic if they are polled after completion.
There was a problem hiding this comment.
Indeed! And to clarify, @ahmedcharles if you find inconsistencies where we panic then that's a bug we should fix!
There was a problem hiding this comment.
It's not quite the same but I think it's what I remember seeing.
There was a problem hiding this comment.
Ok thanks, I fixed that in 8689770
cramertj
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with a few other changes:
Sink::flushcombinator to a freeflushfunctionclosecombinatorCloses #379