Skip to content

don't panic on missing page tags #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2024
Merged

don't panic on missing page tags #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions decodeme/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,13 @@ impl EventDecoder {

let string_data = split_data
.remove(&PageTag::StringData)
.expect("Invalid file: No string data found");
.ok_or("Invalid file: No string data found")?;
let index_data = split_data
.remove(&PageTag::StringIndex)
.expect("Invalid file: No string index data found");
.ok_or("Invalid file: No string index data found")?;
let event_data = split_data
.remove(&PageTag::Events)
.expect("Invalid file: No event data found");
.ok_or("Invalid file: No event data found")?;

Self::from_separate_buffers(string_data, index_data, event_data, diagnostic_file_path)
}
Expand Down
Loading