don't panic on missing page tags #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Dec 22, 2024
Mark-Simulacrum
force-pushed
the
panics
branch
from
dd4e8e2 to
774bbaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today we had an interesting perf run: a try build seemingly created an invalid .mm_profdata file. This caused a panic in the event decoder checks (that, in turn, made the perf collector panic and infinite loop on the same benchmark 😅), although it supports errors in the file header and magic values.
This PR expands the error checking and turns these panics into errors so that they can be handled upstream, even though the file the decoder was asked to read is completely invalid. AFAICT it was only the header that was present -- though I can find out more about it if you want?.