Skip to content

VS Code Marketplace serves old version #11098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnicola opened this issue Dec 22, 2021 · 12 comments · Fixed by #11498
Closed

VS Code Marketplace serves old version #11098

lnicola opened this issue Dec 22, 2021 · 12 comments · Fixed by #11498
Labels
A-vscode vscode plugin issues Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@lnicola
Copy link
Member

lnicola commented Dec 22, 2021

In Code 1.63, it appears that if you try to install the stable version from the Marketplace, you get 0.2.853 instead of 0.2.867 (the latest one). As a work-around, you can switch to the pre-release version, then downgrade to stable.

Filed microsoft/vscode#139628 on the Code side for this.

CC #11026.

@lnicola lnicola added A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug labels Dec 22, 2021
@lnicola lnicola pinned this issue Dec 22, 2021
@lnicola lnicola changed the title VS Code Marketplace serves the wrong version 😱😱😱 [READ THIS] VS Code Marketplace serves the wrong version 😱😱😱 Dec 22, 2021
@lnicola lnicola changed the title 😱😱😱 [READ THIS] VS Code Marketplace serves the wrong version 😱😱😱 😱😱😱 [READ THIS] VS Code Marketplace serves old version 😱😱😱 Dec 22, 2021
@Emerentius
Copy link

The work-around actually downgraded my version from 0.2.867 to 0.2.853 and rerunning it didn't get me back to the newer version. I'm using VS Code (1.63.2).
I ran the work-around to see if there had been a newer release since this issue was created.

You can manually choose the version to install by right-clicking the extension and then selecting "Install different version..." (possibly worded differently). That way I got back to 0.2.867.

Example screenshot (in German).
image

@lnicola
Copy link
Member Author

lnicola commented Dec 27, 2021

There should have been a newer release, but everything runs off GitHub Actions and it's throwing a fit today.

@lnicola
Copy link
Member Author

lnicola commented Dec 27, 2021

Switching to pre-release and back still works for me. And unfortunately it's still needed. I hoped that this would somehow get fixed today, but it didn't.

@ghost
Copy link

ghost commented Dec 28, 2021

On windows, Code 1.63.2, I got silently updated to 0.2.867 (displayed as up to date), I tried to switch to pre-release, then go back to release, and it displayed 0.2.853 with "reload required" but after reload rust-analyzer is v0.2.880 ^^

@jminer
Copy link

jminer commented Dec 31, 2021

Since I'm not seeing newer versions, I just tried the workaround of switching to the pre-release version, and VS Code showed this message:

cant-switch-to-prerelease-rust-analyzer

It should be compatible, right? I don't mind sticking with the older version of rust-analyzer for now, but I thought I'd mention it. I'm using 32-bit VS Code on Windows 10 64-bit.

@lnicola
Copy link
Member Author

lnicola commented Dec 31, 2021

@jminer we don't build 32-bit binaries because it seems pretty easy to go over the 2-3 GB of available address space. There was a workaround to download the 64-bit server on 32-bit Code because we assumed that nobody is actually using a 32-bit version of Windows. If course, this want necessarily true, but nobody complained.

Now Code itself asks for the extension that corresponds to your platform. And since there are no 32-bit builds, you get an error.

@jminer
Copy link

jminer commented Jan 1, 2022

Thanks for the explanation. For programs that don't come close to using 2GB of memory, I try to use 32-bit programs because they use less memory than the 64-bit version. Since I build rust-analyzer's LSP server myself, is there a way for me to still use the extension with 32-bit VS Code without building the extension myself?

For unsupported platforms, I think it would be nice to have an extension build without a bundled server binary. But I don't want extra work done only for me.

(BTW, I happen to also use a 32-bit build of rust-analyzer's LSP server, and I can't remember it ever using more than 1GB of memory. On both ra's codebase and on one project with over 200 transitive dependencies, it's using less than 800MB of virtual memory.)

@lnicola
Copy link
Member Author

lnicola commented Jan 1, 2022

@jminer

For unsupported platforms, I think it would be nice to have an extension build without a bundled server binary. But I don't want extra work done only for me.

That would be https://github.com/rust-analyzer/rust-analyzer/releases/download/2021-12-27/rust-analyzer-no-server.vsix 😄. (thanks to @bjorn3 who made the same argument). You can also install the x64 version and set the server path in the settings. Code should probably show an error, but it currently doesn't.

I can't remember it ever using more than 1GB of memory

That's interesting. Maybe we should also provide 32-bit binaries, then?

@jminer
Copy link

jminer commented Jan 9, 2022

I'm glad to see it already exists. I installed the no-server vsix from the releases page, and it works for me. Thanks!

@lnicola
Copy link
Member Author

lnicola commented Jan 10, 2022

Update: this is now fixed in Code Insiders, but it seems to recommend the pre-release version by default. You can still open the menu and install the stable version.

The next Code version ships in February.

@pravic
Copy link

pravic commented Jan 31, 2022

It looks like we are now forced to "update" RA manually via:

  • Switch to Pre-Release Version
  • Reload
  • Switch to Release Version
  • Reload

@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2022

Installing the extension works fine now 🎉.

@lnicola lnicola closed this as completed Feb 3, 2022
@lnicola lnicola unpinned this issue Feb 4, 2022
@lnicola lnicola changed the title 😱😱😱 [READ THIS] VS Code Marketplace serves old version 😱😱😱 VS Code Marketplace serves old version Feb 18, 2022
bors bot added a commit that referenced this issue Feb 18, 2022
11498: minor: Update issue template r=lnicola a=lnicola

 - remove fixed #11098
 - ask about settings and environment variables

Co-authored-by: Laurențiu Nicola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vscode vscode plugin issues Broken Window Bugs / technical debt to be addressed immediately C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants