Trigger add_vis assist on paths/record fields as well #4273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoFreiberg
force-pushed
the
add_visibility_via_path
branch
3 times, most recently
from
1f9ad2d to
32dbb94
Compare
TimoFreiberg
commented
May 4, 2020
TimoFreiberg
force-pushed
the
add_visibility_via_path
branch
from
32dbb94 to
f35c29f
Compare
TimoFreiberg
changed the title
TimoFreiberg
changed the title
TimoFreiberg
force-pushed
the
add_visibility_via_path
branch
2 times, most recently
from
7339c2d to
91bf7f3
Compare
flodiebold
reviewed
May 10, 2020
There was a problem hiding this comment.
One case where this won't work correctly is with reexports, I think -- e.g. in
mod foo {
use bar::Baz;
mod bar { pub(super) struct Baz; }
}
foo::Baz<|>we'll just change the visibility on the struct declaration, which isn't enough. That's kind of hard to fix though, so I'd probably leave it for now (maybe add a test to document it).
TimoFreiberg
commented
May 10, 2020
TimoFreiberg
force-pushed
the
add_visibility_via_path
branch
from
91bf7f3 to
93038f3
Compare
Union fields apparently don't work :(
TimoFreiberg
force-pushed
the
add_visibility_via_path
branch
from
93038f3 to
e17193d
Compare
TimoFreiberg
commented
May 10, 2020
|
|
||
| #[test] | ||
| #[ignore] | ||
| // FIXME handle reexports properly |
There was a problem hiding this comment.
Added a test for the reexport case
|
r? @flodiebold :-) |
|
bors r+ |
|
Build succeeded: |
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
May 20, 2025
TB: add `Cell` state to support more fine-grained tracking of interior mutable data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4037.
Semantics::resolve_record_fieldseems to not work for union fields, so I think this can be handled in a future PR)