Skip to content

Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound #112151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound #112151

merged 1 commit into from
Jul 30, 2023

Conversation

zopsicle
Copy link
Contributor

It wasn’t quite clear to me how these methods would interpret inclusive bounds so I added examples for those.

@rustbot
Copy link
Collaborator

rustbot commented May 31, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 31, 2023
@workingjubilee
Copy link
Member

Thanks!

r? @workingjubilee

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 30, 2023

📌 Commit aee2b35 has been approved by workingjubilee

It is now in the queue for this repository.

@rustbot rustbot assigned workingjubilee and unassigned m-ou-se Jul 30, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
@fee1-dead fee1-dead mentioned this pull request Jul 30, 2023
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 30, 2023
@fee1-dead
Rollup merge of rust-lang#112151 - chloekek:patch-1, r=workingjubilee
ce359a9 
Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound

It wasn’t quite clear to me how these methods would interpret inclusive bounds so I added examples for those.
@fee1-dead fee1-dead mentioned this pull request Jul 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2023
@bors
Auto merge of rust-lang#114236 - fee1-dead-contrib:rollup-m92j7q1, r=…
4c9ac1e 
…fee1-dead

Rollup of 3 pull requests

Successful merges:

 - rust-lang#112151 (Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound)
 - rust-lang#113512 (Updated lines doc to include trailing carriage return note)
 - rust-lang#114203 (Effects: don't print `host` param in diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3143030 into rust-lang:master Jul 30, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 30, 2023
@zopsicle zopsicle deleted the patch-1 branch July 30, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zopsicle @rustbot @workingjubilee @bors @m-ou-se