Better error message for _ in function signature in impl Trait for Ty
#95395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
changed the title
_ in function signature in impl Trait for Ty
|
r? rust-lang/compiler |
|
r? rust-lang/diagnostics |
oli-obk
requested changes
Apr 23, 2022
oli-obk
added
A-diagnostics
compiler-errors
force-pushed
the
infer-on-impl-for-trait
branch
from
3723812 to
319fbe3
Compare
|
rebased and comments addressed. @bors r=oli-obk |
|
📌 Commit 319fbe3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#95395 (Better error message for `_` in function signature in `impl Trait for Ty`) - rust-lang#96090 (Implement MIR opt unit tests) - rust-lang#96107 ([test] Add test cases for untested functions for VecDeque) - rust-lang#96212 (Use revisions instead of nll compare mode for `/regions/` ui tests) - rust-lang#96215 (Drop support for legacy PM with LLVM 15) - rust-lang#96366 (bootstrap: Remove dead code in rustdoc shim) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Thanks, @compiler-errors ! This looks great; I'm excited to try it. |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 26, 2022
…bank Fix erased region escaping into wfcheck due to rust-lang#95395 We can just use `liberate_late_bound_regions` instead of `erase_late_bound_regions`... This gives us `ReEarlyBound` instead of `ReErased`, the former being something typeck actually knows how to deal with... Fixes rust-lang#96381 Side-note: We only actually get far enough in the compiler pipeline to cause this ICE when we're invoking rustdoc. We actually abort rustc right before wfcheck because of the error that we emit (having `_` in the type signature). Why does rustdoc keep going even though we raise an error?
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 26, 2022
…bank Fix erased region escaping into wfcheck due to rust-lang#95395 We can just use `liberate_late_bound_regions` instead of `erase_late_bound_regions`... This gives us `ReEarlyBound` instead of `ReErased`, the former being something typeck actually knows how to deal with... Fixes rust-lang#96381 Side-note: We only actually get far enough in the compiler pipeline to cause this ICE when we're invoking rustdoc. We actually abort rustc right before wfcheck because of the error that we emit (having `_` in the type signature). Why does rustdoc keep going even though we raise an error?
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 27, 2022
…bank Fix erased region escaping into wfcheck due to rust-lang#95395 We can just use `liberate_late_bound_regions` instead of `erase_late_bound_regions`... This gives us `ReEarlyBound` instead of `ReErased`, the former being something typeck actually knows how to deal with... Fixes rust-lang#96381 Side-note: We only actually get far enough in the compiler pipeline to cause this ICE when we're invoking rustdoc. We actually abort rustc right before wfcheck because of the error that we emit (having `_` in the type signature). Why does rustdoc keep going even though we raise an error?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#92569 (Improve Error Messaging for Unconstructed Structs and Enum Variants in Generic Contexts) - rust-lang#96370 (Cleanup `report_method_error` a bit) - rust-lang#96383 (Fix erased region escaping into wfcheck due to rust-lang#95395) - rust-lang#96385 (Recover most `impl Trait` and `dyn Trait` lifetime bound suggestions under NLL) - rust-lang#96410 (rustdoc: do not write `{{root}}` in `pub use ::foo` docs) - rust-lang#96430 (Fix handling of `!` in rustdoc search) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a replacement suggestion for when
_is present in the function signature forimpl Trait for Ty, using the substitutions from the trait to compute the exact type.Fixes #95097