Skip to content

Fix various issues with CI #39942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged

Conversation

tobiasdiez
Copy link
Contributor

Fix a few issues with CI:

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Apr 15, 2025

Documentation preview for this PR (built with commit 2a67787; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase dimpase self-requested a review April 19, 2025 16:19
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimpase
Copy link
Member

dimpase commented Apr 19, 2025

I see one docker: write /var/lib/docker/tmp/GetImageBlob137043584: no space left on device. CI error

@dimpase dimpase mentioned this pull request Apr 20, 2025
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 21, 2025
sagemathgh-39942: Fix various issues with CI
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fix a few issues with CI:
- Update the systems tested during "CI incremental" to be aligned with
"ci linux" (in particular, no old Fedora 30)
- Remove ubuntu xenial from ci linux since it fails https://github.com/s
agemath/sage/actions/runs/14229865306/job/39878000265
- Fix the macos failures by using a unique artifact name that includes
the stage https://github.com/sagemath/sage/actions/runs/14229865315/job/
39881494483

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39942
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit 93bfdb8 into sagemath:develop Apr 29, 2025
23 of 35 checks passed
@tobiasdiez tobiasdiez deleted the fix-ci-incremental branch May 2, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants