allow gcc-15 from the system #39977

dimpase · 2025-04-19T16:11:38Z

Fedora 42 comes with gcc-15 by default, so it should be allowed, as asked on sage-release

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.

⌛ Dependencies

linbox patches for gcc-15 and Apple clang-17 #39985 : linbox patches
update givaro to 4.2.1 #39936 : givaro 4.2.1

dimpase · 2025-04-19T16:14:10Z

@tobiasdiez - CI still does useless Fedora 30, I don't know why. Can we replace it with Fedora 42 - this would test this PR, too

enriqueartal · 2025-04-19T17:01:00Z

The packages gap, singular and planarity have problems which can be solved using system package. I attarch the log for ecl.
ecl-24.5.10.log

dimpase · 2025-04-19T19:18:55Z

does Fedora have a usable ecl package?

I'll report this to upstream ecl, perhaps they already have a fix

enriqueartal · 2025-04-19T19:21:37Z

Not now. I have used a former src.rpm and I could produce a package using gcc-14. Then maxima produces also an error, I am trying to make a package maxima-runtime-ecl (again with gcc-14) which has been disabled in Fedora.

enriqueartal · 2025-04-19T20:46:04Z

With ecl and maxima system packages I get errors in sagelib,
sagelib-10.7.beta1.log
If I am not wrong they are related with linbox and ecl.

By the way, patch system package (2.8.1) is not accepted, no clue why in config.log

dimpase · 2025-04-19T20:49:01Z

Note that gcc-15 has default c23 C standard. This is a bump from c17. Adding -std=c17 to CFLAGS might help with ecl and maxima.

That is,

--- a/build/pkgs/ecl/spkg-install.in
+++ b/build/pkgs/ecl/spkg-install.in
@@ -1,6 +1,6 @@
 cd src
 
-export CFLAGS
+export CFLAGS="-std=c17 $CFLAGS"
 export CXXFLAGS
 export LDFLAGS

(and maxima gets its flags from ecl).

dimpase · 2025-04-19T20:51:36Z

By the way, patch system package (2.8.1) is not accepted, no clue why in config.log
most probably it reports its version as 2.8, that's why. Anyway, this is fixed by #39943
(testing appreciated)

github-actions · 2025-04-19T21:42:14Z

Documentation preview for this PR (built with commit 64e347f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

enriqueartal · 2025-04-19T21:58:45Z

No luck with sagelib with or without system-packages. On the other side, patch is no longer a package using #39943

dimpase · 2025-04-19T22:09:42Z

By the way, patch system package (2.8.1) is not accepted, no clue why in config.log
most probably it reports its version as 2.8, that's why. Anyway, this is fixed by #39943
(testing appreciated)

dimpase · 2025-04-19T22:09:58Z

ECL problem reported here:
https://gitlab.com/embeddable-common-lisp/ecl/-/issues/775

dimpase · 2025-04-19T22:11:28Z

No luck with sagelib with or without system-packages.

please post errors. Are they again due to c23 used for C, or there are also C++ issues?

enriqueartal · 2025-04-20T08:15:29Z

Thanks. I am not sure how to proceed. First I modified spkg-install.in as in #39977 (comment). I attach sagelib-10.7.beta1.log using ecl and system packages. Then I remove ecl system package, and this is the log of failure: ecl-24.5.10.log. Finally, I tried to compile maxima with ecl system package: maxima-5.47.0.log.
I hope it may help.

tobiasdiez · 2025-04-20T09:23:41Z

@tobiasdiez - CI still does useless Fedora 30, I don't know why. Can we replace it with Fedora 42 - this would test this PR, too

Sure, just edit

sage/.github/workflows/ci-linux-incremental.yml

Line 102 in e0cf1e4

"fedora-40",]

and the ci-linux.

dimpase · 2025-04-20T18:46:03Z

@enriqueartal : in regard of ecl, can you replace c17 in CFLAGS with gnu17

i.e. in the patch above it should be

-export CFLAGS
+export CFLAGS="-std=gnu17 $CFLAGS"

enriqueartal · 2025-04-20T19:10:32Z

One step achieved. Now ecl and maxima are OK; still issues with sagelib regarding ecl and linbox.

dimpase · 2025-04-20T19:32:46Z

@tobiasdiez - CI still does useless Fedora 30, I don't know why. Can we replace it with Fedora 42 - this would test this PR, too

Sure, just edit

sage/.github/workflows/ci-linux-incremental.yml

Line 102 in e0cf1e4

"fedora-40",]

and the ci-linux.

How about doing this on top of your recent PR updating CI? (I meant #39942)

dimpase · 2025-04-20T20:02:32Z

One step achieved. Now ecl and maxima are OK; still issues with sagelib regarding ecl and linbox.

I see issues with linbox (more patches needed)

With ecl, running plane C (gcc) while building sage.matrix.matrix_numpy_integer_dense extension, and anything else which includes ecl.h, should be done with -std=gnu17.
Can you try something like

CFLAGS="-std=gnu17" make -j8 build

@tobiasdiez - what to do here in meson.build? Does it have something line extension_data_c, analogous to extension_data_cpp ? (I am still unable to use meson docs - e.g. I cannot find anything in extension_data_cpp)

enriqueartal · 2025-04-20T20:15:31Z

I think ecl's issues are gone, still issues with linbox with sagelib
sagelib-10.7.beta1.log

dimpase · 2025-04-20T20:34:33Z

Do you use system's givaro? Or a built one? Anyway, please try #39936 (for givaro - but it's important, as linbox depends on givaro)

enriqueartal · 2025-04-20T21:03:40Z

I use system's givaro (4.2.1). I can try with spkg.

dimpase · 2025-04-20T21:11:00Z

I use system's givaro (4.2.1). I can try with spkg.

It's fine, should make no difference. For linbox, I think, 2 more patches are needed (incidentally they are needed for the new Apple's clang 17), as I added here: https://github.com/Macaulay2/homebrew-tap/blob/main/Formula/linbox.rb

Specifically, add to build/pkgs/linbox/patches "https://github.com/linbox-team/linbox/commit/d1f618fb0ee4a84be3ccddcfc28b257f34e1cbf7.patch?full_index=1"
and "https://github.com/linbox-team/linbox/commit/4a1e1395804d4630ec556c61ba3f2cb67e140248.patch?full_index=1"
(save them as 41.patch and 42.patch, so that they apply in the order following the rest of the patches)

enriqueartal · 2025-04-20T21:29:49Z

Ok for linbox spkg but sagelib not OK

dimpase · 2025-04-20T21:46:21Z

I gather linbox needs

--- a/linbox/blackbox/block-hankel.h
+++ b/linbox/blackbox/block-hankel.h
@@ -345,8 +345,8 @@ namespace LinBox
 		template<class Vector1, class Vector2>
 		Vector1& apply(Vector1 &x, const Vector2 &y) const
 		{
-			linbox_check(this->_coldim == y.size());
-			linbox_check(this->_rowdim == x.size());
+			linbox_check(this->coldim() == y.size());
+			linbox_check(this->rowdim() == x.size());
 			BlasMatrixDomain<Field> BMD(field());
 #ifdef BHANKEL_TIMER
 			_chrono.clear();

as well

dimpase · 2025-04-20T21:47:41Z

and probably more, from linbox PRs 320, 322

enriqueartal · 2025-04-20T21:55:49Z

Thanks! I saved as 43.patch and now it works. If my memory is OK gap and singular had also issues with gcc-15; for gap, even outside sage.

enriqueartal · 2025-04-20T22:03:02Z

Last thing for today: gap spkg is OK, not for singular. Thanks.

enriqueartal · 2025-04-20T22:07:24Z

and probably more, from linbox PRs 320, 322

I used nothing from these PRs

dimpase · 2025-05-01T16:20:05Z

gap_packages might need gcc-15 fixes. please post errors here, or on a new issue

dimpase · 2025-05-01T16:23:44Z

we can place CFLAGS="-std=gnu17 into spkg-install.m4 files, something like

export CFLAGS = "-std=gnu17 $CFLAGS"

(check the precise syntax in similar places)

enriqueartal · 2025-05-01T22:30:09Z

Adding this line to spkg-install.m4 file of sagelib and export CFLAGS="-std=gnu17 $CFLAGS_NON_NATIVE" to the one of gap, it works. For gap_packages, only guava needs this line, but semigroups does not work, see
semigroups.log
In fedora there is a small issue with the location of some planarity files, creating some symbolic links the problems are gone.

dimpase · 2025-05-02T00:01:01Z

the tests pass, please review

enriqueartal · 2025-05-02T07:13:04Z

Is there any test machine running gcc 15?

enriqueartal · 2025-05-02T13:43:32Z

I cannot find anymore the message below. Did you got it? For me, maxima worked using the spkg-install.in file for ecl in this PR. I used planarity system package. Forcing spkg gave an error but it goes away adding export CFLAGS = "-std=gnu17 $CFLAGS" in the spkg-install.in file for planarity.
Still no way to get semigroups built

@enriqueartal how can i reproduce your successful build?

here's what i've tried:

git reset --hard && git clean -dfX
git pull --rebase [https://github.com/dimpase/sage.git](https://urldefense.com/v3/__https://github.com/dimpase/sage.git__;!!D9dNQwwGXtA!UiqZqOz6c0X6rWZL2kGi5EkWlEd0LS_mXb9uzmcj_h2vWOjKpWCjIjGj3Id9gj8tGg66XL3XkXJLGbTuoJRakiY$)
git pull --rebase [https://github.com/dimpase/sage.git](https://urldefense.com/v3/__https://github.com/dimpase/sage.git__;!!D9dNQwwGXtA!UiqZqOz6c0X6rWZL2kGi5EkWlEd0LS_mXb9uzmcj_h2vWOjKpWCjIjGj3Id9gj8tGg66XL3XkXJLGbTuoJRakiY$) linbox_fixes_gcc15_clang17
git pull --rebase [https://github.com/dimpase/sage.git](https://urldefense.com/v3/__https://github.com/dimpase/sage.git__;!!D9dNQwwGXtA!UiqZqOz6c0X6rWZL2kGi5EkWlEd0LS_mXb9uzmcj_h2vWOjKpWCjIjGj3Id9gj8tGg66XL3XkXJLGbTuoJRakiY$) test442332
make configure
./configure
make -j $(nproc) build

didnt work sadly, still the same problem with maxima and planarity```

dimpase · 2025-05-02T16:54:56Z

Does the latest Semigroups build for you stand-alone? https://semigroups.github.io/Semigroups/

enriqueartal · 2025-05-02T17:19:58Z

Unfortunately, not:

En el fichero incluido desde ./bin/include/libsemigroups/sims1.hpp:1269,
                 desde src/pkg.cpp:59:
./bin/include/libsemigroups/sims1.tpp: In member function ‘libsemigroups::Sims1<T>::iterator_base& libsemigroups::Sims1<T>::iterator_base::operator=(libsemigroups::Sims1<T>::iterator_base&&)’:
./bin/include/libsemigroups/sims1.tpp:622:39: error: ‘class libsemigroups::Sims1<T>::iterator_base’ has no member named ‘long_rules’ [-Wtemplate-body]
  622 |     _longs           = std::move(that.long_rules());
      |                                       ^~~~~~~~~~
make: *** [Makefile.gappkg:130: gen/src/pkg.o] Error 1

I think it is the same error.

enriqueartal · 2025-05-02T17:26:50Z

In the rpm of fedora there is this patch

dimpase · 2025-05-02T17:49:10Z

Let us do optional packages on another PR, depending on this one. Can we get this one positively reviewed and move on?

enriqueartal · 2025-05-02T18:06:15Z

Agree with gap_packages. There are a couple of things:

Singular built only after Singular 4.4.1 + Flint 3.3.2 #40033. It is unclear to me which is the direction for dependence.
There are some more spkg-install.in modified files: gap, planarity, and sagelib.
With these changes, for me it is OK.

dimpase · 2025-05-02T22:08:43Z

#40033 is not a dependency here

nbruin · 2025-05-02T23:10:02Z

I tried a build on dimpase/develop on F42 and things failed in planarity, in the same way as in the log that enriqueartal already attached.

restarting with

CFLAGS="-std=gnu17" make -j20 build

got me a little further, but ultimately things crashed in linbox (which I wasn't able to install via system packages due to some version conflict) which complained with "cc1plus: warning: command-line option '-std=gnu17' is valid for C/ObjC but not for C++" and then produced:

[spkg-install] ../../linbox/vector/blas-subvector.h:121:20: error: 'LinBox::BlasSubvector<_Vector>::Self_t' has no member named 'data'; did you mean 'at'? [-Wtemplate-body]

dimpase · 2025-05-03T00:02:01Z

this one is needed for mere allowing the use of gcc-15. It's not promising you that everything works with it as well.

can we please do things incrementally.
This PR does not break anything

dimpase · 2025-05-03T00:12:06Z

Please open a separate issue for planarity, put logs there, and link it to this PR. Do not spam this PR with things which are beyond its scope.

enriqueartal · 2025-05-03T07:48:10Z

Planarity built for me adding the line in spk-install.in; this way linbox is built without the gnu17 thing.

enriqueartal · 2025-05-03T07:54:24Z

Maybe this is spam in this PR but the CFLAGS line allowed to build ecl; similar lines allow to build gap, planarity, and sagelib. If not, one has to deal with several runs of make with or without gnu17. Is it bad to add these lines to the four packages instead to only ecl?

sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):

sagemathgh-39977: allow gcc-15 from the system Fedora 42 comes with gcc-15 by default, so it should be allowed, as asked on [sage-release](https://groups.google.com/g/sage- release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ) ## 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies    - sagemath#39985 : linbox patches - sagemath#39936 : givaro 4.2.1 URL: sagemath#39977 Reported by: Dima Pasechnik Reviewer(s):

sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) EDIT Homebrew/homebrew-core#222142 has been merged, so now you can install singular from Homebrew and use it! ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):

sagemathgh-39977: allow gcc-15 from the system Fedora 42 comes with gcc-15 by default, so it should be allowed, as asked on [sage-release](https://groups.google.com/g/sage- release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ) ## 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies    - sagemath#39985 : linbox patches - sagemath#39936 : givaro 4.2.1 URL: sagemath#39977 Reported by: Dima Pasechnik Reviewer(s):

sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) EDIT Homebrew/homebrew-core#222142 has been merged, so now you can install singular from Homebrew and use it! ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):

dimpase requested a review from tobiasdiez April 19, 2025 16:14

github-actions bot added the s: needs review label Apr 19, 2025

dimpase requested a review from nbruin May 2, 2025 00:00

dimpase mentioned this pull request May 2, 2025

Singular 4.4.1 + Flint 3.3.2 #40033

Merged

5 tasks

erentar mentioned this pull request May 4, 2025

Build failure in Fedora 42 with gcc 15 #40047

Open

2 tasks

vbraun added the s: positive review label May 4, 2025

dimpase removed the s: needs review label May 9, 2025

vbraun merged commit fa4855f into sagemath:develop May 11, 2025
27 checks passed

github-actions bot removed the s: positive review label May 11, 2025

Uh oh!

allow gcc-15 from the system #39977

allow gcc-15 from the system #39977

Uh oh!

Conversation

dimpase commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

dimpase commented Apr 19, 2025

Uh oh!

enriqueartal commented Apr 19, 2025

Uh oh!

dimpase commented Apr 19, 2025

Uh oh!

enriqueartal commented Apr 19, 2025

Uh oh!

enriqueartal commented Apr 19, 2025

Uh oh!

dimpase commented Apr 19, 2025

Uh oh!

dimpase commented Apr 19, 2025

Uh oh!

github-actions bot commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enriqueartal commented Apr 19, 2025

Uh oh!

dimpase commented Apr 19, 2025

Uh oh!

dimpase commented Apr 19, 2025

Uh oh!

dimpase commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

tobiasdiez commented Apr 20, 2025

Uh oh!

dimpase commented Apr 20, 2025

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

dimpase commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimpase commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

dimpase commented Apr 20, 2025

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

dimpase commented Apr 20, 2025

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

dimpase commented Apr 20, 2025

Uh oh!

dimpase commented Apr 20, 2025

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

enriqueartal commented Apr 20, 2025

Uh oh!

dimpase commented May 1, 2025

Uh oh!

dimpase commented May 1, 2025

Uh oh!

enriqueartal commented May 1, 2025

Uh oh!

dimpase commented May 2, 2025

Uh oh!

enriqueartal commented May 2, 2025

Uh oh!

dimpase commented Apr 19, 2025 •

edited

Loading

github-actions bot commented Apr 19, 2025 •

edited

Loading

dimpase commented Apr 19, 2025 •

edited

Loading

dimpase commented Apr 20, 2025 •

edited

Loading

dimpase commented Apr 20, 2025 •

edited

Loading

nbruin commented May 2, 2025 •

edited

Loading