Linbox patch

[edgarcosta]

This patch fixes on OSX

[spkg-install] ../../linbox/vector/blas-subvector.h:121:20: error: no member named 'data' in 'BlasSubvector<_Vector>'
[spkg-install]   121 |             _ptr(V.data()+beg), _size(dim), _inc(inc), _field(&V.field()) {}
[spkg-install]       |                  ~ ^

g++ -std=gnu++11 -g -O2 -Isage/libs/flint -I/Applications/sage/src -I/Applications/sage/local/var/lib/sage/venv-python3.13/lib/python3.13/site-packages/numpy/_core/include -I/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.13/include/python3.13 -I/Applications/sage/local/var/lib/sage/venv-python3.13/include -I/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.13/include/python3.13 -c sage/libs/linbox/linbox_flint_interface.cpp -o build/temp.macosx-15.0-arm64-cpython-313/sage/libs/linbox/linbox_flint_interface.o -DDISABLE_COMMENTATOR -DFFLAS_COMPILED -DFFPACK_COMPILED -std=gnu++11
    In file included from sage/libs/linbox/linbox_flint_interface.cpp:1963:
    In file included from /Applications/sage/local/include/linbox/solutions/charpoly.h:34:
    In file included from /Applications/sage/local/include/linbox/algorithms/bbcharpoly.h:46:
    In file included from /Applications/sage/local/include/linbox/solutions/det.h:608:
    In file included from /Applications/sage/local/include/linbox/algorithms/det-rational.h:41:
    In file included from /Applications/sage/local/include/linbox/algorithms/last-invariant-factor.h:30:
    In file included from /Applications/sage/local/include/linbox/algorithms/rational-solver.h:583:
    In file included from /Applications/sage/local/include/linbox/algorithms/./dixon-solver/dixon-solver-dense.h:363:
    In file included from /Applications/sage/local/include/linbox/algorithms/./dixon-solver/./dixon-solver-dense.inl:26:
    In file included from /Applications/sage/local/include/linbox/algorithms/lifting-container.h:49:
    In file included from /Applications/sage/local/include/linbox/blackbox/block-hankel-inverse.h:36:
    /Applications/sage/local/include/linbox/blackbox/block-hankel.h:348:23: error: no member named '_coldim' in 'BlockHankel<_Field>'; did you mean 'coldim'?
      348 |                         linbox_check(this->_coldim == y.size());
          |                                            ^~~~~~~
          |                                            coldim

By applying:
linbox-team/linbox@4a1e139?w=1#diff-6344b04fac6de3b0e7ff00458910d867c9ee947aff5797a459c0e2c9403da1f4L118-L124)
Mentioned here linbox-team/linbox#320

and a subset of linbox-team/linbox#323

[github-actions]

Documentation preview for this PR (built with commit c2c0ca8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

[dimpase]

isn't it included here: #39985 ?

[dimpase]

it's already in a positively reviewed PR

[dimpase]

sorry, you could have at least searched for the recent PRs saying linbox in the subject (and reviewed them)

[edgarcosta]

sorry. the frustration battling the build system won over me.

[dimpase]

Never mind. It seems that we need a better organisation of the routine parts of the development process. E.g. even if someone posts a PR to fix the build issues, and even posts a link to it on one of our google groups, noone is keen on reviewing it. Or people start reviewing, find they it's only a partial fix, and stall.