Skip to content

linbox patches for gcc-15 and Apple clang-17 #39985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Apr 21, 2025

Linbox needs patches for gcc-15 and Apple clang-17

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Apr 21, 2025

Documentation preview for this PR (built with commit 90b8952; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase dimpase force-pushed the linbox_fixes_gcc15_clang17 branch from 228a71d to 90b8952 Compare April 30, 2025 16:47
@dimpase dimpase requested review from dcoudert and enriqueartal May 1, 2025 16:43
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this PR, I can compile linbox on macOS 15.4.1. It's failing without it.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-39977: allow gcc-15 from the system
    
Fedora 42 comes with gcc-15 by default, so it should be allowed, as
asked on [sage-release](https://groups.google.com/g/sage-
release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ)


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- sagemath#39985 : linbox patches
- sagemath#39936 : givaro 4.2.1
    
URL: sagemath#39977
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-39977: allow gcc-15 from the system
    
Fedora 42 comes with gcc-15 by default, so it should be allowed, as
asked on [sage-release](https://groups.google.com/g/sage-
release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ)


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- sagemath#39985 : linbox patches
- sagemath#39936 : givaro 4.2.1
    
URL: sagemath#39977
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
@dimpase dimpase mentioned this pull request May 9, 2025
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2025
sagemathgh-39977: allow gcc-15 from the system
    
Fedora 42 comes with gcc-15 by default, so it should be allowed, as
asked on [sage-release](https://groups.google.com/g/sage-
release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ)


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- sagemath#39985 : linbox patches
- sagemath#39936 : givaro 4.2.1
    
URL: sagemath#39977
Reported by: Dima Pasechnik
Reviewer(s):
@vbraun vbraun merged commit 725c4ed into sagemath:develop May 11, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants