-
-
Notifications
You must be signed in to change notification settings - Fork 619
linbox patches for gcc-15 and Apple clang-17 #39985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit 90b8952; changes) is ready! 🎉 |
228a71d
to
90b8952
Compare
dcoudert
approved these changes
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this PR, I can compile linbox on macOS 15.4.1. It's failing without it.
LGTM.
2 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 4, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17 Linbox needs patches for gcc-15 and Apple clang-17 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39936: givaro update to 4.2.1 URL: sagemath#39985 Reported by: Dima Pasechnik Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 5, 2025
sagemathgh-39977: allow gcc-15 from the system Fedora 42 comes with gcc-15 by default, so it should be allowed, as asked on [sage-release](https://groups.google.com/g/sage- release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ) ## 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39985 : linbox patches - sagemath#39936 : givaro 4.2.1 URL: sagemath#39977 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 5, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17 Linbox needs patches for gcc-15 and Apple clang-17 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39936: givaro update to 4.2.1 URL: sagemath#39985 Reported by: Dima Pasechnik Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-39977: allow gcc-15 from the system Fedora 42 comes with gcc-15 by default, so it should be allowed, as asked on [sage-release](https://groups.google.com/g/sage- release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ) ## 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39985 : linbox patches - sagemath#39936 : givaro 4.2.1 URL: sagemath#39977 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17 Linbox needs patches for gcc-15 and Apple clang-17 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39936: givaro update to 4.2.1 URL: sagemath#39985 Reported by: Dima Pasechnik Reviewer(s): David Coudert
Closed
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2025
sagemathgh-39977: allow gcc-15 from the system Fedora 42 comes with gcc-15 by default, so it should be allowed, as asked on [sage-release](https://groups.google.com/g/sage- release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ) ## 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39985 : linbox patches - sagemath#39936 : givaro 4.2.1 URL: sagemath#39977 Reported by: Dima Pasechnik Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linbox needs patches for gcc-15 and Apple clang-17
📝 Checklist
⌛ Dependencies