Skip to content

pvl_getISDdata.m and pvl_readtmy3.m update #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2016

Conversation

DanRiley
Copy link
Collaborator

Updates pvl_getISDdata.m to use the Haversine function to find the distance between a given Lat/Lon and the Lat/Lon of an ISD site. Previous version used a hypotenuse calculation which is not applicable near the poles.
Also updated pvl_getISDdata.m with input parsing.
Also updated pvl_getISDdata.m to use the filesep character instead of a hardcoded "/" when changing directories.

Updates pvl_readtmy3.m to be able to read TMY3 files from before the January 2015 TMY3 update and after the January 2015 TMY3 update.

@DanRiley
Copy link
Collaborator Author

I still need to update the changelog with these changes... unless we want to get rid of the changelog due to the use of github?

@wholmgren
Copy link

Dan is using GitHub and making pull requests! This makes it so much easier for me to see what you all are changing. I feel like we changed something about TMY file parsing last year, but I'll have to go check...

I recommend keeping a change log but using a simple txt file instead of docx. For what it's worth, I've been making a separate whats new file for each release:

https://github.com/pvlib/pvlib-python/tree/master/docs/sphinx/source/whatsnew

You can ignore the little bit of markup that gets parsed by the Sphinx documentation building program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants