Skip to content

Fix eta-expanding guards in adaptType #19960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix eta-expanding guards in adaptType #19960

wants to merge 2 commits into from

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Mar 16, 2024 •
edited
Loading

Fixes #19942

@dwijnand dwijnand marked this pull request as ready for review March 16, 2024 21:00
@dwijnand dwijnand requested a review from odersky March 16, 2024 21:00
@dwijnand
Copy link
Member Author

@odersky let me know if you have any ideas on what we should do with typeParams giving different answers for the same type def.

@odersky
Copy link
Contributor

odersky commented Mar 16, 2024

I have no immediate ideas. Can you find out why typeParams is not stable?

@dwijnand
Copy link
Member Author

Yeah, I wrote it in the comment. First we get the symbols from the TypeDef's RHS, which I think is a LambdaTypeTree. But then that lambda becomes a lambda type, so then we start getting LambdaParams instead.

@dwijnand dwijnand mentioned this pull request Mar 18, 2024
Merged
@dwijnand
Copy link
Member Author

Extended in #19974

@dwijnand dwijnand closed this Mar 18, 2024
@dwijnand dwijnand deleted the eta-breaks-implicits-question-mark branch March 18, 2024 13:31
odersky added a commit that referenced this pull request Mar 18, 2024
@odersky
Make sure typeParams returns a stable result even in the presence of …
5dc6860 
…completions (#19974)

Fixes #19942 

Based on #19960 

@dwijnand I would have pushed onto the original PR if it had been on
staging. Better to always push to staging, not your own repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky Awaiting requested review from odersky

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in 7mind/izumi for implicit search / typer
2 participants
@dwijnand @odersky