Highlight current heading in shortcuts #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for scientific-python-hugo-theme ready! 🔨 Explore the source changes: 637ae26 🔍 Inspect the deploy log: https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/61fb8549dc89960007c9fc8b 😎 Browse the preview: https://deploy-preview-116--scientific-python-hugo-theme.netlify.app |
stefanv
added a commit
to stefanv/scientific-python.org
that referenced
this pull request
Feb 3, 2022
stefanv
force-pushed
the
scrolling-shortcuts
branch
2 times, most recently
from
bc8b100 to
c8c4c02
Compare
Also: - Modify location bar so that anchor URLs can be copied and referred to - Add a list icon a-la pydata-sphinx-theme (but use MUI icon instead of FontAwesome) - Improve the way the shortcut list is generated: anchors now come directly from Hugo - Prevent shortcut list from scrolling off-screen
stefanv
force-pushed
the
scrolling-shortcuts
branch
from
c8c4c02 to
637ae26
Compare
|
Did you want to change the name from |
|
I was thinking we can do that in another PR (it's not a user-visible change, so not as urgent). |
|
LGTM!! |
jarrodmillman
approved these changes
Feb 3, 2022
jarrodmillman
pushed a commit
to stefanv/scientific-python.org
that referenced
this pull request
Feb 3, 2022
jarrodmillman
pushed a commit
to scientific-python/scientific-python.org
that referenced
this pull request
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: