Various fixes #267
Various fixes #267
Conversation
Pull Request validationSuccess🟢 CI - All checks have passed Auto MergeFailed🔴 Pull Request has unsupported target branch Success🟢 Pull Request is not marked as draft and it's not blocked by |
|
[test-all] |
Testing Farm results
|
|
[test] |
|
[test] |
|
[test] |
|
[test] |
|
Hi @phracek, this MR is ready for review. After some experimentation, I only included non-intrusive changes into this MR. We discussed applying the same changes to other containerfiles too. As I changed the metadata (started using variables there), do we have any elegant way to diff the metadata of released image and one with these changes ? |
Sure. I extended the change to the all relevant 10.11 containerfiles.
Do you really wish to extend this change to the 10.5 images too? !! WARNING !!
But this is a topic for discussion. |
|
[test] |
…dibility, so they are easier to spot in the text thanks to the clear variable name boundaries
…erfile
WARNING:
this introduces the ${NAME} environmental variable to the RHEL 9 and C9S variants !
…work
- utilize the ${MYSQL_VERSION} variable through the containerfile
- replace all ${VERSION} with ${MYSQL_VERSION}
- introduce ${MYSQL_SHORT_VERSION} environment variable
- utilize the ${MYSQL_SHORT_VERSION} variable through the containerfile
- move all DB version variables together
Removal of seemingly redundant ${VERSION} variable was discussed.
Great caution should be employed when removing existing environment variables,
as users can depend on them.
${VERSION} is currently kept for the compatibility purposes
Change of ${MYSQL_VERSION} to ${MARIADB_VERSION} variable was discussed.
Convincing positives not found at this moment. Might reconsider later.
- note: ${MYSQL_VERSION} is also used in scripts outside of the containerfile
- note: in case of removal of ${MYSQL_VERSION}, caution is advised as described above.
WARNING:
this introduces the ${VERSION} environmental variable to the RHEL 9 and C9S variants !
|
I checked that the 10.5 container-files do not contain any new caveats, and extended the change to them, specifically:
|
|
[test] |
No description provided.