Add test dependencies to setup.py #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitpaulk
force-pushed
the
rohitpaulk/consolidate-test-deps
branch
from
972e9d1 to
66651c2
Compare
rohitpaulk
force-pushed
the
rohitpaulk/consolidate-test-deps
branch
6 times, most recently
from
08c4067 to
68bf500
Compare
Also replaced tests_require with extras_require. The test command (which tests_required was used for) was deprecated in setuptools 41.5.0. Ref: pypa/setuptools#1878
Also, prefer latest Debian versions over jessie/stretch
rohitpaulk
force-pushed
the
rohitpaulk/consolidate-test-deps
branch
from
68bf500 to
ca7fd5e
Compare
rohitpaulk
force-pushed
the
rohitpaulk/consolidate-test-deps
branch
from
4bfc6bb to
09c8fd3
Compare
rohitpaulk
force-pushed
the
rohitpaulk/consolidate-test-deps
branch
from
09c8fd3 to
92011b3
Compare
|
Looks like there were test failures on master, I've extracted that out into #165. |
|
Found a cleaner way to do this without special handling for 3.4. Re-opening as #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Ensures that test dependencies are defined in one place. Fixes #148