Cleanup CircleCI config #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 6 6
Lines 371 371
Branches 38 38
=======================================
Hits 344 344
Misses 21 21
Partials 6 6 Continue to review full report at Codecov.
|
Also replaced tests_require with extras_require. The test command (which tests_required was used for) was deprecated in setuptools 41.5.0.
rohitpaulk
force-pushed
the
rohitpaulk/cleanup-circleci-config
branch
2 times, most recently
from
8875eda to
3696afa
Compare
rohitpaulk
force-pushed
the
rohitpaulk/cleanup-circleci-config
branch
from
3696afa to
2b3c831
Compare
rohitpaulk
force-pushed
the
rohitpaulk/cleanup-circleci-config
branch
2 times, most recently
from
72ab01b to
ace671e
Compare
Includes special handling for the circleci/python:3.4 image, which doesn't setup PATH properly. This isn't worth fixing right now, as it is likely that we'll deprecate Python 3.4 support very soon.
rohitpaulk
force-pushed
the
rohitpaulk/cleanup-circleci-config
branch
from
ace671e to
84ea6ad
Compare
lubird
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from #165.
setup.py, fixes Strange Compiling error w/ make #148.