Skip to content

/deep/ syntax is deprecated #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimin9038 opened this issue Jul 23, 2021 · 2 comments · Fixed by #233
Closed

/deep/ syntax is deprecated #184

jimin9038 opened this issue Jul 23, 2021 · 2 comments · Fixed by #233
Labels
FE Frontend tasks refactor Fix code hierarchy and improve code readability

Comments

@jimin9038
Copy link
Member

jimin9038 commented Jul 23, 2021

/deep/ syntax는 dart-sass 에서는 이미 사용이 불가능하고, node-sass에서는 deprecated 상태입니다. (현재 node-sass 사용 중)

https://stackoverflow.com/questions/48032006/how-do-i-use-deep-or-or-v-deep-in-vue-js 에 따라
/deep syntax를 ::v-deep syntax로 변경하면 될 것 같습니다.

(node-sass는 deprecated된 상태고, dart-sass로 migrating할 때 고쳐야하므로 미리 해두면 좋을 것 같네요.)

@jimin9038 jimin9038 added FE Frontend tasks refactor Fix code hierarchy and improve code readability labels Jul 23, 2021
@dotoleeoak
Copy link
Member

::v-deep을 쓰는 것보단 아예 deep 문법 자체를 가능하면 쓰지 않는 것이 좋을 것 같습니다. 전에 deep을 사용항 이유가 bootstrap에 정의된 style을 overriding하려고 한건데, bootstrap의 일부 css만 포함시키거나(예: grid 시스템만 사용 or bootstrap-vue component만 사용) class 이름을 바꾸는 등의 방법으로 deep 사용을 자제하는 것이 좋겠습니다.

@dotoleeoak dotoleeoak changed the title /deep/ syntax deprecated 문제 /deep/ syntax is deprecated Jul 24, 2021
@jimin9038
Copy link
Member Author

Vue 3 & typescript enhancement #180 와 같이 처리할 예정

dotoleeoak added a commit that referenced this issue Sep 9, 2021
Deprecated된 문법인 /deep/ syntax를 ::v-deep syntax로 대체

Closes #184, #185
dotoleeoak added a commit that referenced this issue Sep 11, 2021
Deprecated된 문법인 /deep/ syntax를 ::v-deep syntax로 대체

Closes #184, #185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Frontend tasks refactor Fix code hierarchy and improve code readability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants