Skip to content

Unable to build aws-smithy-checksums in MacOS ARM using nightly toolchains post 14th May #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
navasvarela opened this issue May 30, 2024 · 7 comments

Comments

@navasvarela
Copy link

When trying to compile a project in MacOS ARM (Sonoma), using any nightly toolchain after 2024-05-14, the following error occurs:

error[E0635]: unknown feature `stdarch_arm_crc32`
  --> USER_HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32c-0.6.5/src/lib.rs:23:60
   |
23 | #![cfg_attr(all(target_arch = "aarch64", nightly), feature(stdarch_arm_crc32))]
   |                                                            ^^^^^^^^^^^^^^^^^

aws-smithy-checksums depends on crc32c version 0.6.5. This version of crc32c uses a feature that was removed on 14th May and causes compilation errors (see rust-lang/stdarch#1573). This problem has been fixed in subsequent releases of crc32c. It seems that the fix for this should be relatively simple.

@aajtodd
Copy link
Contributor

aajtodd commented May 30, 2024

Pinning crc32c was done here to work around build failures and ensure the SDK can continue to be released.

The underlying issue doesn't appear to be resolved/released and so until then we'll be pinned to 0.6.5.

@orlp
Copy link

orlp commented Jun 3, 2024

@aajtodd That does mean anything that uses aws-smithy-checksums, which includes aws-sdk-s3 simply does not build on the latest nightly on ARM, which includes all developers on Apple M* laptops.

@aajtodd
Copy link
Contributor

aajtodd commented Jun 4, 2024

Understood. This is blocked on a release of crc32c that fixes this issue right now. It looks like a fix was committed for zowens/crc32c#67 but has not yet made it into a release.

@Andrewp2
Copy link

Andrewp2 commented Jun 9, 2024

I think that commit has made it into 0.6.8
zowens/crc32c#70
https://crates.io/crates/crc32c/0.6.8

github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
## Motivation and Context
#3672

## Description
Pin to a newer working version of `crc32c` (will still pin to a
particular version to avoid a breaking change, until the lockfile
protection is available)

## Testing
- Verified locally build of `aws-smithy-checksums` with the updated
`crc32c`

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@ysaito1001
Copy link
Contributor

ysaito1001 commented Jun 12, 2024

We just released a new aws-smithy-checksums that depends on crc32c version 0.6.8. Could you try compiling your project and see if it works now?

@Andrewp2
Copy link

My project is working, which compiles to AWS Lambda ARM. I don't have a mac device to check there.

@navasvarela
Copy link
Author

I can confirm that this works now for me in my Mac

@Velfi Velfi closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants