Skip to content

Pin crc32c to avoid build.rs failure #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged

Pin crc32c to avoid build.rs failure #3665

merged 1 commit into from
May 28, 2024

Conversation

ysaito1001
Copy link
Contributor

Motivation and Context

Works around zowens/crc32c#67


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ysaito1001 ysaito1001 requested a review from a team as a code owner May 28, 2024 18:03
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Discussed offline and the semver failure is likely due to the comparison against aws-sdk-s3 which isn't impacted by this pinning

@ysaito1001 ysaito1001 added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit d00acc3 May 28, 2024
43 of 44 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/pin-crc32c branch May 28, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants