Skip to content

Sync release candidate #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 27, 2020
Merged

Sync release candidate #251

merged 17 commits into from
Aug 27, 2020

Conversation

oclyke
Copy link
Contributor

@oclyke oclyke commented Aug 27, 2020

branches got twisted

nseidle and others added 17 commits June 26, 2020 13:51
Bringing up to date with release1.1.2
I hate to undo even a little bit of Adam's good work, but in the interests of a robust core, I think it's best the references to time.h are removed, and the Epoch set/get along with it.

RTC.cpp included <time.h>, which caused a compilation error when these are also included in code:
#include <Time.h>
#include <TimeLib.h>

Some possible issues with Window lack of case sensitivity, refer here: https://forum.arduino.cc/index.php?topic=451360.0

Also with time.h (or Time.h?) being an optional extra install library to the Arduino IDE, best to leave it out of the core, especially if it can cause compilation errors.
this keeps room around for the legacy BLE led example
A few libraries rely on this ability.
@oclyke oclyke merged commit 27b2f5f into release-candidate Aug 27, 2020
@oclyke oclyke deleted the sync-release-candidate branch August 27, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants