This repository was archived by the owner on May 14, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update database section of ref guide #5082
Update database section of ref guide #5082
Changes from all commits
993dfb1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noob question, Is there a case where we do not include the H2 driver? If they don't specify a datasource dataflow defaults to H2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So....
The
H2
config was split into its own config and made optional in #4802 as it was lighting up CVE scans.We quickly realized the missing dep. broke running locally w/
java -jar
as well as many examples that do the same in the docs. Because of this I made the dependency non-optional here.As of now the dependency is still provided. We need to decide what we are going to do in this area (provide it or not). This doc is written as if it will be removed. Lets leave it like that for now and we will re-address the docs when we make a decision on H2.
Sound good @cppwfs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this and we can follow on w/ whatever we need to.