Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Add AppBootVersion to 'app register' shell/client #5240

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Mar 3, 2023

  • Introduces the AppBootVersion enum
  • Hooks into 'app register' shell command
  • Passes boot version into AppRegistryController

See #5239

Steps to exercise

  • build code in the branch w/ ./mvnw clean install -DskipTests
  • start server w/ java -jar spring-cloud-dataflow-server/target/spring-cloud-dataflow-server-2.10.2-SNAPSHOT.jar
  • start shell w/ java -jar spring-cloud-dataflow-shell/target/spring-cloud-dataflow-shell-2.10.2-SNAPSHOT.jar
  • in shell register boot2 app w/o boot version
    dataflow>app register --type task --force --name timestamp --uri maven://org.springframework.cloud.task.app:task-timestamp:3.2.0
    
  • in shell register boot2 app w/ boot version
    dataflow>app register --type task --force --name timestamp --uri maven://org.springframework.cloud.task.app:task-timestamp:3.2.0 --bootVersion 2
    
  • in shell register boot3 app w/ boot version
    dataflow>app register --type task --force --name timestamp --uri maven://org.springframework.cloud.task.app:task-timestamp:3.2.0 --bootVersion 3
    

The output from the shell is as follows for boot2

Successfully registered application 'task:timestamp'

The output from the shell is as follows for boot3

Successfully registered application 'task:timestamp' (boot 3)

@onobc onobc requested a review from corneil March 3, 2023 04:54
- Introduces the AppBootVersion enum
- Hooks into 'app register' shell command
- Passes boot version into AppRegistryController

See spring-attic#5239
@onobc onobc force-pushed the cbono-add-boot3-shell-option branch from 3855ce4 to 649e766 Compare March 3, 2023 05:01
@onobc onobc requested review from cppwfs and markpollack March 3, 2023 05:04
@corneil
Copy link
Contributor

corneil commented Mar 3, 2023

I would remove the prefixes and description from the enum. I've submitted a commit to your repo.

@onobc
Copy link
Contributor Author

onobc commented Mar 3, 2023

I would remove the prefixes and description from the enum. I've submitted a commit to your repo.

What is the benefit of moving the static information out of the enum? Ultimately it will be pulled into a row in the DB.

@corneil corneil force-pushed the cbono-add-boot3-shell-option branch from ec5fba5 to c33aa71 Compare March 3, 2023 16:03
@onobc onobc merged commit 4f10587 into spring-attic:main Mar 3, 2023
@onobc onobc deleted the cbono-add-boot3-shell-option branch March 3, 2023 19:24
onobc added a commit to onobc/spring-cloud-dataflow that referenced this pull request Mar 7, 2023
onobc added a commit that referenced this pull request Mar 7, 2023
onobc added a commit to onobc/spring-cloud-dataflow that referenced this pull request Mar 9, 2023
- Introduces the `AppBootSchemaVersion` enum
- Add bootVersion param to 'app register' shell
- Add bootVersion param to AppRegistryController

See spring-attic#5239

Co-authored-by: Corneil du Plessis <[email protected]>
onobc added a commit that referenced this pull request Mar 9, 2023
- Introduces the `AppBootSchemaVersion` enum
- Add bootVersion param to 'app register' shell
- Add bootVersion param to AppRegistryController

See #5239

Co-authored-by: Corneil du Plessis <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants