This repository was archived by the owner on May 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 590
Add AppBootVersion to 'app register' shell/client #5240
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces the AppBootVersion enum - Hooks into 'app register' shell command - Passes boot version into AppRegistryController See spring-attic#5239
3855ce4
to
649e766
Compare
I would remove the prefixes and description from the enum. I've submitted a commit to your repo. |
What is the benefit of moving the static information out of the enum? Ultimately it will be pulled into a row in the DB. |
onobc
commented
Mar 3, 2023
...ataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppBootSchemaVersion.java
Outdated
Show resolved
Hide resolved
onobc
commented
Mar 3, 2023
...ataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppBootSchemaVersion.java
Outdated
Show resolved
Hide resolved
onobc
commented
Mar 3, 2023
...ataflow-core/src/main/java/org/springframework/cloud/dataflow/core/AppBootSchemaVersion.java
Outdated
Show resolved
Hide resolved
ec5fba5
to
c33aa71
Compare
onobc
commented
Mar 3, 2023
...main/java/org/springframework/cloud/dataflow/registry/service/DefaultAppRegistryService.java
Show resolved
Hide resolved
onobc
added a commit
to onobc/spring-cloud-dataflow
that referenced
this pull request
Mar 7, 2023
This reverts commit 4f10587.
onobc
added a commit
to onobc/spring-cloud-dataflow
that referenced
this pull request
Mar 9, 2023
- Introduces the `AppBootSchemaVersion` enum - Add bootVersion param to 'app register' shell - Add bootVersion param to AppRegistryController See spring-attic#5239 Co-authored-by: Corneil du Plessis <[email protected]>
onobc
added a commit
that referenced
this pull request
Mar 9, 2023
- Introduces the `AppBootSchemaVersion` enum - Add bootVersion param to 'app register' shell - Add bootVersion param to AppRegistryController See #5239 Co-authored-by: Corneil du Plessis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5239
Steps to exercise
./mvnw clean install -DskipTests
java -jar spring-cloud-dataflow-server/target/spring-cloud-dataflow-server-2.10.2-SNAPSHOT.jar
java -jar spring-cloud-dataflow-shell/target/spring-cloud-dataflow-shell-2.10.2-SNAPSHOT.jar
The output from the shell is as follows for boot2
The output from the shell is as follows for boot3