Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Shell / CLI support for Task 3.0 #5239

Closed
4 tasks done
onobc opened this issue Mar 3, 2023 · 1 comment
Closed
4 tasks done

Shell / CLI support for Task 3.0 #5239

onobc opened this issue Mar 3, 2023 · 1 comment
Assignees
@onobc
Milestone
2.11.0-RC1

Comments

@onobc
Copy link
Contributor

onobc commented Mar 3, 2023 •
edited
Loading

The CLI command defined in the class AppRegistryCommands will require updates for several of its commands:

  • Register - add bootVersion argument with a default value of 2. Only values of 2 or 3 are accepted, otherwise error.
  • Info - needs to list boot version
  • defaultApplication - The argument gets converted to QualifiedApplicationName which does not include “bootVersion” not needed to invoke method - apps must already exist
  • importFromResource - probably needs work because one would also indicate a boot3 application in there. (done on the backend)

importFromResource notes

Import of apps via property files, e.g. with the addition of a .bootVersion key value pair.

source.cdc-debezium=maven://org.springframework.cloud.stream.app:cdc-debezium-source-rabbit:3.2.1
source.cdc-debezium.metadata=maven://org.springframework.cloud.stream.app:cdc-debezium-source-rabbit:jar:metadata:3.2.1
source.cdc-debezium.bootVersion=3
@onobc onobc self-assigned this Mar 3, 2023
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 3, 2023
@onobc
Add AppBootVersion to 'app register' shell/client
3855ce4 
- Introduces the AppBootVersion enum
- Hooks into 'app register' shell command
- Passes boot version into AppRegistryController

See spring-attic#5239
@onobc onobc mentioned this issue Mar 3, 2023
Merged
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 3, 2023
@onobc
Add AppBootVersion to 'app register' shell/client
649e766 
- Introduces the AppBootVersion enum
- Hooks into 'app register' shell command
- Passes boot version into AppRegistryController

See spring-attic#5239
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 3, 2023
@onobc
Adjust formatting and make params consistent
6ecb29a 
See spring-attic#5239
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 3, 2023
@onobc
Use ParameterizedTest
9736a11 
See spring-attic#5239
onobc added a commit that referenced this issue Mar 3, 2023
@onobc
Add boot version to 'app register' flow (#5240)
4f10587 
- Introduces the `AppBootSchemaVersion` enum
- Add bootVersion param to 'app register' shell
- Add bootVersion param to AppRegistryController

See #5239

Co-authored-by: Corneil du Plessis <[email protected]>
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 7, 2023
@onobc
Add tests for shell 'app register' commands
55a486f 
- Create AppRegistryCommandsTests that verify
  newly added bootVersion options

See spring-attic#5239
@onobc onobc mentioned this issue Mar 7, 2023
Merged
onobc added a commit that referenced this issue Mar 7, 2023
@onobc
Add tests for shell 'app register' commands
95114a3 
- Create AppRegistryCommandsTests that verify
  newly added bootVersion options

See #5239
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 9, 2023
@onobc
Add boot version to 'app register' flow (spring-attic#5240)
f4064bc 
- Introduces the `AppBootSchemaVersion` enum
- Add bootVersion param to 'app register' shell
- Add bootVersion param to AppRegistryController

See spring-attic#5239

Co-authored-by: Corneil du Plessis <[email protected]>
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Mar 9, 2023
@onobc
Add tests for shell 'app register' commands
6bcc514 
- Create AppRegistryCommandsTests that verify
  newly added bootVersion options

See spring-attic#5239
onobc added a commit that referenced this issue Mar 9, 2023
@onobc
Add boot version to 'app register' flow (#5240)
f80369f 
- Introduces the `AppBootSchemaVersion` enum
- Add bootVersion param to 'app register' shell
- Add bootVersion param to AppRegistryController

See #5239

Co-authored-by: Corneil du Plessis <[email protected]>
onobc added a commit that referenced this issue Mar 9, 2023
@onobc
Add tests for shell 'app register' commands
3ba26b0 
- Create AppRegistryCommandsTests that verify
  newly added bootVersion options

See #5239
@onobc onobc added this to the 2.11.0 milestone May 18, 2023
@corneil corneil moved this to In Progress in SCDF 2.11 RC1 May 18, 2023
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue May 19, 2023
@onobc
Add boot version to app info shell command
be2969d 
- Update related tests to Junit5

See spring-attic#5239
@onobc onobc mentioned this issue May 19, 2023
Merged
corneil pushed a commit that referenced this issue May 19, 2023
@onobc
Add boot version to app info shell command (#5351)
c8707c6 
* Add boot version to `app info` shell command

- Update related tests to Junit5

See #5239

* Reduce test duplication
@markpollack markpollack moved this from In Progress to Done in SCDF 2.11 RC1 May 23, 2023
@onobc
Copy link
Contributor Author

onobc commented May 23, 2023

Closed via c8707c6

@onobc onobc closed this as completed May 23, 2023
@onobc onobc modified the milestones: 2.11.0, 2.11.0-RC1 Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@onobc onobc

Labels
None yet
Milestone
2.11.0-RC1
Development

No branches or pull requests
1 participant
@onobc