This repository was archived by the owner on May 14, 2025. It is now read-only.
Add boot version to app info shell command
#5351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update related tests to Junit5 See spring-attic#5239
onobc
commented
May 19, 2023
| @@ -12,7 +12,7 @@ | |||
| <description>Spring Cloud Data Flow Docs</description> | |||
| <properties> | |||
| <main.basedir>${basedir}/..</main.basedir> | |||
| <docs.resources.version>0.2.1.RELEASE</docs.resources.version> | |||
| <docs.resources.version>0.2.5</docs.resources.version> | |||
There was a problem hiding this comment.
[UNRELATED] 0.2.1.RELEASE not available in snapshots nor central, 0.2.5 is what we need to be using which is in fact on central.
onobc
commented
May 19, 2023
| import org.junit.BeforeClass; | ||
| import org.junit.Rule; | ||
| import org.junit.rules.TestName; | ||
| import org.junit.jupiter.api.AfterAll; |
There was a problem hiding this comment.
[UNRELATED] I converted the app registry test to Junit5 and therefore had to do the same across the test inheritance hieararchy.
onobc
commented
May 19, 2023
| @@ -77,7 +77,7 @@ public class ConfigCommandTests { | |||
|
|
|||
| @Before | |||
| public void setUp() { | |||
| MockitoAnnotations.initMocks(this); | |||
| MockitoAnnotations.openMocks(this); | |||
There was a problem hiding this comment.
[UNRELATED] initMocks is deprecated
onobc
commented
May 19, 2023
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>repackage</goal> |
There was a problem hiding this comment.
[UNRELATED] this was not being called during clean install which resulted in non-executable shell jar.
corneil
approved these changes
May 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5239