Skip to content

Polish RefreshScopeBeanDefinitionEnhancer.setRefreshable() #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2018
Merged

Polish RefreshScopeBeanDefinitionEnhancer.setRefreshable() #362

merged 1 commit into from
May 1, 2018

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Apr 30, 2018

If this.refreshables and refreshables are the same instance, invoking addAll() isn't necessary.

@ryanjbaxter
Copy link
Contributor

Why not just move the addAll call inside the if instead of changing the logic?

@izeye izeye force-pushed the polish-20180430 branch from 05a19cb to b15e8c9 Compare April 30, 2018 23:55
@izeye
Copy link
Contributor Author

izeye commented May 1, 2018

@ryanjbaxter Thanks for the feedback! I usually handles exceptional cases first. I guess it's just my habit or style although it sometimes reduces nested block depths. In this case your suggestion looks better, so I updated as you suggested.

@ryanjbaxter ryanjbaxter added this to the 2.0.0.RELEASE milestone May 1, 2018
@ryanjbaxter ryanjbaxter merged commit dbac0f0 into spring-cloud:master May 1, 2018
@izeye izeye deleted the polish-20180430 branch May 1, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.RC2
Development

Successfully merging this pull request may close these issues.
2 participants
@izeye @ryanjbaxter