Skip to content

When one app fails to deploy in a stream, the stream status is "all apps failed to deploy" #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markpollack opened this issue Jan 24, 2018 · 1 comment
Assignees
Labels
type/bug Is a bug report
Milestone

Comments

@markpollack
Copy link
Contributor

This is an incorrect message.
This is what was observed when testing with skipper and investigating the issue with escaping quote characters. The transformer app failed to start, the runtime apps command was accurate reporting what was running and what had failed.

@ilayaperumalg
Copy link
Contributor

Just to confirm this is not a regression, this behavior is what we see in 1.2.x as well:

dataflow:>stream list
╔══════════╤══════════════════════════════════════════╤══════════════════════════╗
║  Stream  │            Stream Definition             │          Status          ║
║   Name   │                                          │                          ║
╠══════════╪══════════════════════════════════════════╪══════════════════════════╣
║a1        │time --server.port=9191 | log             │All apps have failed      ║
║          │--server.port=9191                        │deployment                ║
╚══════════╧══════════════════════════════════════════╧══════════════════════════╝

dataflow:>runtime apps 
╔════════════════════╤═══════════╤═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╗
║App Id / Instance Id│Unit Status│                                                        No. of Instances / Attributes                                                        ║
╠════════════════════╪═══════════╪═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╣
║a1.log              │  failed   │                                                                      1                                                                      ║
╟┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┼┈┈┈┈┈┈┈┈┈┈┈┼┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈╢
║                    │           │       guid = 9191                                                                                                                           ║
║                    │           │        pid = 7868                                                                                                                           ║
║                    │           │       port = 9191                                                                                                                           ║
║a1.log-0            │  failed   │     stderr = /var/folders/_p/csftb5612z33pgd9ltfbp0mr0000gn/T/spring-cloud-dataflow-189337312540347280/a1-1516948929386/a1.log/stderr_0.log ║
║                    │           │     stdout = /var/folders/_p/csftb5612z33pgd9ltfbp0mr0000gn/T/spring-cloud-dataflow-189337312540347280/a1-1516948929386/a1.log/stdout_0.log ║
║                    │           │        url = http://192.168.1.100:9191                                                                                                      ║
║                    │           │working.dir = /var/folders/_p/csftb5612z33pgd9ltfbp0mr0000gn/T/spring-cloud-dataflow-189337312540347280/a1-1516948929386/a1.log              ║
╟────────────────────┼───────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╢
║a1.time             │ deployed  │                                                                      1                                                                      ║
╟┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┼┈┈┈┈┈┈┈┈┈┈┈┼┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈╢
║                    │           │       guid = 9191                                                                                                                           ║
║                    │           │        pid = 7869                                                                                                                           ║
║                    │           │       port = 9191                                                                                                                           ║
║a1.time-0           │ deployed  │     stderr = /var/folders/_p/csftb5612z33pgd9ltfbp0mr0000gn/T/spring-cloud-dataflow-189337312540347280/a1-1516948929426/a1.time/stderr_0.log║
║                    │           │     stdout = /var/folders/_p/csftb5612z33pgd9ltfbp0mr0000gn/T/spring-cloud-dataflow-189337312540347280/a1-1516948929426/a1.time/stdout_0.log║
║                    │           │        url = http://192.168.1.100:9191                                                                                                      ║
║                    │           │working.dir = /var/folders/_p/csftb5612z33pgd9ltfbp0mr0000gn/T/spring-cloud-dataflow-189337312540347280/a1-1516948929426/a1.time             ║
╚════════════════════╧═══════════╧═════════════════════════════════════════════════════════════════════════════════════════════════════════════════

ilayaperumalg added a commit to ilayaperumalg/spring-cloud-dataflow that referenced this issue Jan 26, 2018
 - If the stream has at least one of the apps successfully deployed but at least one of the apps has failed, then the aggregate state needs to be set to `partital` instead of `failed`
  - This state will show the appropriate status description as:
`In the case of multiple apps, some have successfully deployed, while others have not`

Resolves spring-cloud#1974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

3 participants