Fix partial aggregate deployment state #1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the stream has at least one of the apps successfully deployed but at least one of the apps has failed, then the aggregate state needs to be set to `partital` instead of `failed` - This state will show the appropriate status description as: `In the case of multiple apps, some have successfully deployed, while others have not` Resolves spring-cloud#1974
Codecov Report
@@ Coverage Diff @@
## master #1996 +/- ##
============================================
+ Coverage 63.52% 63.55% +0.03%
- Complexity 1950 1954 +4
============================================
Files 310 310
Lines 9104 9107 +3
Branches 1123 1124 +1
============================================
+ Hits 5783 5788 +5
+ Misses 2944 2942 -2
Partials 377 377
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partitalinstead offailedIn the case of multiple apps, some have successfully deployed, while others have notResolves #1974