Skip to content

Switch to CompletableFuture #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Jul 21, 2022 · 0 comments · Fixed by #1481
Closed

Switch to CompletableFuture #1473

garyrussell opened this issue Jul 21, 2022 · 0 comments · Fixed by #1481
Labels
type: enhancement
Milestone
3.0.0-M4

Comments

@garyrussell
Copy link
Contributor

Spring is planning on deprecating ListenableFuture in 6.0.

spring-projects/spring-framework#27780

Add methods that use CompletableFuture to the templates and deprecate those that return ListenableFuture so we can remove them and have a clean API in 3.0.
@garyrussell garyrussell added this to the 3.0.0-M4 milestone Jul 21, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 27, 2022
@garyrussell
spring-projectsGH-1473: Switch to CompletableFuture
967f817 
Resolves spring-projects#1473

Given the stability of the project, it was simplest to copy the `AsyncRabbitTemplate`
rather than adding a lot of conditional code.

**2.4.x only; I will submit a separate PR for main**
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 27, 2022
@garyrussell
spring-projectsGH-1473: Switch to CompletableFuture
fb90f6c 
Resolves spring-projects#1473

Given the stability of the project, it was simplest to copy the `AsyncRabbitTemplate`
rather than adding a lot of conditional code.

**2.4.x only; I will submit a separate PR for main**
@garyrussell garyrussell mentioned this issue Jul 27, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 27, 2022
@garyrussell @artembilan
GH-1473: Switch to CompletableFuture
439ccd1 
Resolves #1473

Given the stability of the project, it was simplest to copy the `AsyncRabbitTemplate`
rather than adding a lot of conditional code.

**2.4.x only; I will submit a separate PR for main**
garyrussell added a commit that referenced this issue Jul 27, 2022
@garyrussell
GH-1473: Fix Unused Import
fac71c4
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1473: Move RabbitFutures to Top Level Classes
2607a51 
- to aid migration from 2.4.x to 3.0.x so that the return types will not change
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1473: Move RabbitFutures to Top Level Classes
994a4c9 
- to aid migration from 2.4.x to 3.0.x so that the return types will not change
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1473: Move RabbitFutures to Top Level Classes
da9dd0c 
- to aid migration from 2.4.x to 3.0.x so that the return types will not change
artembilan pushed a commit that referenced this issue Jul 28, 2022
@garyrussell
GH-1473: Move RabbitFutures to Top Level Classes
038f8f6 
- to aid migration from 2.4.x to 3.0.x so that the return types will not change

* Increase test coverage.
* Fix since.
* Add author to new files.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1473: Switch to CompletableFuture
1c2b5b9 
Resolves spring-projects#1473

Given the stability of the project, it was simplest to copy the `AsyncRabbitTemplate`
rather than adding a lot of conditional code.

**2.4.x only; I will submit a separate PR for main**

spring-projectsGH-1473: Fix Unused Import

spring-projectsGH-1473: Move RabbitFutures to Top Level Classes

- to aid migration from 2.4.x to 3.0.x so that the return types will not change

* Increase test coverage.
* Fix since.
* Add author to new files.

Remove async template; rename async template2.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1473: Switch to CompletableFuture
b715e3c 
Resolves spring-projects#1473

Given the stability of the project, it was simplest to copy the `AsyncRabbitTemplate`
rather than adding a lot of conditional code.

**2.4.x only; I will submit a separate PR for main**

spring-projectsGH-1473: Fix Unused Import

spring-projectsGH-1473: Move RabbitFutures to Top Level Classes

- to aid migration from 2.4.x to 3.0.x so that the return types will not change

* Increase test coverage.
* Fix since.
* Add author to new files.

Remove async template; rename async template2.
@garyrussell garyrussell mentioned this issue Jul 28, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 28, 2022
@garyrussell
GH-1473: Switch to CompletableFuture
b03a0bc 
Resolves #1473

* Deprecate `AsyncRabbitTemplate2`.
* Copy implementation from  `AsyncRabbitTemplate2` to `AsyncRabbitTemplate`
* Fix other `ListenableFuture` usages.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 13, 2022
@garyrussell
spring-projectsGH-1473: Revert CompletableFuture Changes
009ec4e 
See spring-projects#1473
See spring-projects#1480

- caused problems with Boot auto configuration
- since 3.0 is a major release, switching to CF there is not onerous
- retain `CompletableFuture` as an async return type
@garyrussell garyrussell mentioned this issue Sep 13, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 13, 2022
@garyrussell @artembilan
GH-1473: Revert CompletableFuture Changes
2746ebe 
See #1473
See #1480

- caused problems with Boot auto configuration
- since 3.0 is a major release, switching to CF there is not onerous
- retain `CompletableFuture` as an async return type
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 13, 2022
@garyrussell
spring-projectsGH-1473: Remove Unnecessary Deprecated Interfaces
0b34f84 
See spring-projects#1473
See spring-projects#1480

Migration interfaces to assist moving to `CompletableFuture` have been
removed from 2.4.x due to Boot auto configuration issues.

Therefore, these interfaces never existed in a released version of 2.4.x.
@garyrussell garyrussell mentioned this issue Sep 13, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 13, 2022
@garyrussell @artembilan
GH-1473: Remove Unnecessary Deprecated Interfaces
80f8c9c 
See #1473
See #1480

Migration interfaces to assist moving to `CompletableFuture` have been
removed from 2.4.x due to Boot auto configuration issues.

Therefore, these interfaces never existed in a released version of 2.4.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

Successfully merging a pull request may close this issue.

GH-1473: Switch to CompletableFuture garyrussell/spring-amqp
1 participant
@garyrussell