Skip to content

Switch to CompletableFuture in spring-rabbit-stream #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Jul 28, 2022 · 0 comments · Fixed by #1482
Closed

Switch to CompletableFuture in spring-rabbit-stream #1480

garyrussell opened this issue Jul 28, 2022 · 0 comments · Fixed by #1482
Labels
backport:2.4.x (obsolete) type: enhancement
Milestone
3.0.0-M4

Comments

@garyrussell
Copy link
Contributor

No description provided.

@garyrussell garyrussell added this to the 3.0.0-M4 milestone Jul 28, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1480: Switch to CompletableFuture in s-r-stream
26687ad 
Resolves spring-projects#1480

Also reinstate deprecated `AsyncAmqpTemplate2`.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1480: Switch to CompletableFuture in s-r-stream
6da38e7 
Resolves spring-projects#1480
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1480: Switch to CompletableFuture in s-r-stream
de74f57 
Resolves spring-projects#1480
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 28, 2022
@garyrussell
spring-projectsGH-1480: Switch to CompletableFuture in s-r-stream
20cdc8c 
Resolves spring-projects#1480

Also reinstate deprecated `AsyncAmqpTemplate2`.
This was referenced Jul 28, 2022
Merged
Merged
artembilan pushed a commit that referenced this issue Jul 28, 2022
@garyrussell @artembilan
GH-1480: Switch to CompletableFuture in s-r-stream
67bfec9 
Resolves #1480
artembilan pushed a commit that referenced this issue Jul 28, 2022
@garyrussell @artembilan
GH-1480: Switch to CompletableFuture in s-r-stream
97a508e 
Resolves #1480

Also reinstate deprecated `AsyncAmqpTemplate2`.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 13, 2022
@garyrussell
spring-projectsGH-1473: Revert CompletableFuture Changes
009ec4e 
See spring-projects#1473
See spring-projects#1480

- caused problems with Boot auto configuration
- since 3.0 is a major release, switching to CF there is not onerous
- retain `CompletableFuture` as an async return type
@garyrussell garyrussell mentioned this issue Sep 13, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 13, 2022
@garyrussell @artembilan
GH-1473: Revert CompletableFuture Changes
2746ebe 
See #1473
See #1480

- caused problems with Boot auto configuration
- since 3.0 is a major release, switching to CF there is not onerous
- retain `CompletableFuture` as an async return type
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Sep 13, 2022
@garyrussell
spring-projectsGH-1473: Remove Unnecessary Deprecated Interfaces
0b34f84 
See spring-projects#1473
See spring-projects#1480

Migration interfaces to assist moving to `CompletableFuture` have been
removed from 2.4.x due to Boot auto configuration issues.

Therefore, these interfaces never existed in a released version of 2.4.x.
@garyrussell garyrussell mentioned this issue Sep 13, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 13, 2022
@garyrussell @artembilan
GH-1473: Remove Unnecessary Deprecated Interfaces
80f8c9c 
See #1473
See #1480

Migration interfaces to assist moving to `CompletableFuture` have been
removed from 2.4.x due to Boot auto configuration issues.

Therefore, these interfaces never existed in a released version of 2.4.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport:2.4.x (obsolete) type: enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

Successfully merging a pull request may close this issue.

GH-1480: Switch to CompletableFuture in s-r-stream garyrussell/spring-amqp
1 participant
@garyrussell