Skip to content

Move MVC metrics auto-configuration to the new Observation instrumentation #32538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Sep 29, 2022 · 0 comments
Closed

Move MVC metrics auto-configuration to the new Observation instrumentation #32538

bclozel opened this issue Sep 29, 2022 · 0 comments
Assignees
@bclozel
Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Milestone
3.0.0-RC1

Comments

@bclozel
Copy link
Member

bclozel commented Sep 29, 2022

Since spring-projects/spring-framework#28880, Spring Framework now instruments directly Spring MVC with the HttpRequestsObservationFilter, removing the need for a custom WebMvcMetricsFilter.

With this issue, we should update the auto-configuration to only rely on the new ObservationRegistry and configure the instrumentation available on Spring MVC. We need to provide a smooth upgrade experience: deprecate the tags providers and adapt them to the new infrastructure until it's completely removed.
@bclozel bclozel added type: enhancement A general enhancement theme: observability Issues related to observability labels Sep 29, 2022
@bclozel bclozel added this to the 3.0.0-RC1 milestone Sep 29, 2022
@bclozel bclozel self-assigned this Sep 29, 2022
@Buzzardo Buzzardo mentioned this issue Oct 10, 2022
Closed
shakuzen added a commit to micrometer-metrics/micrometer-samples that referenced this issue Oct 20, 2022
@shakuzen
Remove workarounds now that there is auto-config for MVC
1ebf5ac 
See spring-projects/spring-boot#32538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-RC1
Development

No branches or pull requests
1 participant
@bclozel