Instrument MVC and WebFlux for Observability #28880
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
theme: observability
An issue related to observability and tracing
type: enhancement
A general enhancement
Milestone
Comments
bclozel
added
in: web
Closed
bclozel
added a commit
that referenced
this issue
Sep 12, 2022
This commit introduces the new `HttpRequestsObservationFilter` This `Filter` can be used to instrument Servlet-based web frameworks for Micrometer Observations. While the Servlet request and responses are automatically used for extracting KeyValues for observations, web frameworks still need to provide the matching URL pattern, if supported. This can be done by fetching the observation context from the request attributes and contributing to it. This commit instruments Spring MVC (annotation and functional variants), effectively replacing Spring Boot's `WebMvcMetricsFilter`. See gh-28880
bclozel
added a commit
that referenced
this issue
Sep 12, 2022
This commit introduces a `HttpRequestsObservationWebFilter` which instruments web frameworks using Spring's reactive `ServerHttpRequest` and `ServerHttpResponse` interfaces. This replaces Spring Boot's `MetricsWebFilter`. See gh-28880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, Spring MVC and WebFlux applications are instrumented wit Micrometer metrics in Spring Boot, thanks to
org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilterandorg.springframework.boot.actuate.metrics.web.reactive.server.MetricsWebFilter. Those filters are then auto-configured by Spring Boot and their metrics exported with the metrics system.While those are timing request handling properly, the extraction of metadata can be complex since it requires inner knowledge of the web framework and is sometimes limited because it would need direct access to the request handling.
With the introduction of
Observationin Micrometer 1.10, Spring Framework is now instrumenting directly some of its features.This issue aims at instrumenting the MVC and WebFlux web frameworks for the
"http.server.requests"observation.The text was updated successfully, but these errors were encountered: