Skip to content

Annotation APIs should not have compile scope #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Apr 19, 2022 · 1 comment
Closed

Annotation APIs should not have compile scope #1400

snicoll opened this issue Apr 19, 2022 · 1 comment
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@snicoll
Copy link
Member

snicoll commented Apr 19, 2022

Support of QueryDSL has moved annotation-api to compile scope, see c288d05#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L163

I don't think it should be a mandatory dependency of this module. Shouldn't it be provided instead? Noticed with 4.4.0-RC1
This was referenced Apr 19, 2022
Closed
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 19, 2022
@mikereiche
Copy link
Collaborator

mikereiche commented Apr 19, 2022 •
edited
Loading

It seems I can remove the dependency completely from pom.xml in 4.4.x - is that the correct change? It is not present in the 5.x/main branch. @snicoll

mikereiche added a commit that referenced this issue Apr 19, 2022
@mikereiche
Remove explicit dependency on annotations api.
c29a4e9 
Closes #1400.
@mikereiche mikereiche mentioned this issue Apr 19, 2022
Merged
5 tasks
mikereiche added a commit that referenced this issue Apr 20, 2022
@mikereiche
Remove explicit dependency on annotations api. (#1403)
316e665 
Closes #1400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snicoll @spring-projects-issues @mikereiche