Skip to content

Remove explicit dependency on annotations api. #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikereiche
Copy link
Collaborator

Closes #1400.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@mikereiche mikereiche requested a review from snicoll April 19, 2022 18:19
@snicoll
Copy link
Member

snicoll commented Apr 20, 2022

@mikereiche sorry I can't review this PR. I am merely reporting that a change brought a dependency that wasn't there before. For our own purpose, this commit addresses the problem but I can't say if that's the right fix for this project.

@mikereiche mikereiche merged commit 316e665 into 4.4.x Apr 20, 2022
@mikereiche mikereiche deleted the datacouch_1400_remove_explicit_dependency_on_annotations_api branch May 3, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants