Skip to content

spring.ftl is missing in spring-webflux #22950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DerThanne opened this issue May 13, 2019 · 5 comments
Closed

spring.ftl is missing in spring-webflux #22950

DerThanne opened this issue May 13, 2019 · 5 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@DerThanne
Copy link

DerThanne commented May 13, 2019 •
edited by sbrannen
Loading

Affects: spring-webflux 5.1.6

In org.springframework.web.reactive.result.view.freemarker.FreeMarkerConfigurer the spring.ftl is mentioned, but actually does not exist.

I tried to use the one shipped with spring-webmc, but that led to further problems.

Please provide a webflux ready version of the ftl.

Thank you!
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 13, 2019
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label May 13, 2019
@sbrannen sbrannen changed the title /spring.ftl is missing in spring webflux spring.ftl is missing in spring-webflux May 13, 2019
@rstoyanchev
Copy link
Contributor

Indeed we're missing the spring.ftl macros in WebFlux. It should be the same more or less, as the one in spring-webmvc, but without any macros that rely on methods not present in the WebFlux RequestContext like the ones related to themes.

@rstoyanchev rstoyanchev added type: enhancement A general enhancement status: ideal-for-contribution An issue that a contributor can help us with and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 15, 2019
@rstoyanchev rstoyanchev added this to the 5.x Backlog milestone May 15, 2019
@Ambeebee

This comment has been minimized.

Sign in to view
@ielatif
Copy link
Contributor

ielatif commented May 20, 2019

@rstoyanchev I would like to pick up this plz

@rstoyanchev
Copy link
Contributor

Just go ahead and submit a PR.

This was referenced May 20, 2019
Closed
Closed
@sbrannen
Copy link
Member

Superseded by PR #23002

@sbrannen sbrannen removed this from the 5.x Backlog milestone May 23, 2019
@rstoyanchev rstoyanchev added the status: superseded An issue that has been superseded by another label May 23, 2019
@sbrannen sbrannen removed the status: ideal-for-contribution An issue that a contributor can help us with label May 26, 2019
@sbrannen sbrannen modified the milestone: 5.2 M3 May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sbrannen @rstoyanchev @ielatif @spring-projects-issues @DerThanne @Ambeebee