Skip to content

Add FreeMarker macro support in spring-webflux #23002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add FreeMarker macro support in spring-webflux #23002

wants to merge 3 commits into from

Conversation

ielatif
Copy link
Contributor

@ielatif ielatif commented May 20, 2019 •
edited by sbrannen
Loading

See #22950 for details.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 20, 2019
@ielatif ielatif marked this pull request as ready for review May 20, 2019 20:14
@sbrannen sbrannen changed the title Add FreeMarker macros Add FreeMarker macros in spring-webflux May 23, 2019
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 23, 2019
@sbrannen sbrannen mentioned this pull request May 23, 2019
Closed
sbrannen
sbrannen requested changes May 23, 2019
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested two minor changes.

Please introduce tests for this functionality as well.

Thanks in advance!

@sbrannen sbrannen added this to the 5.x Backlog milestone May 23, 2019
@sbrannen sbrannen mentioned this pull request May 26, 2019
Closed
@ielatif
Copy link
Contributor Author

ielatif commented May 27, 2019

Please introduce tests for this functionality as well

Done 👍

sbrannen
sbrannen requested changes May 28, 2019
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the recent changes and adding the tests!

Unfortunately, we have recently switched to AssertJ for all assertions. So the test classes will fail the build due to Checkstyle violations.

Please update the tests to use AssertJ instead of Hamcrest and JUnit 4.

You can use the latest versions (in master) of the test classes you copied as a basis.

Thanks in advance.

@ielatif
Copy link
Contributor Author

ielatif commented May 28, 2019

@sbrannen Thanks.
Migrated JUnit 4 assertions to AssertJ

@sbrannen sbrannen modified the milestones: 5.x Backlog, 5.2 M3 May 28, 2019
@sbrannen sbrannen self-assigned this May 28, 2019
@sbrannen sbrannen changed the title Add FreeMarker macros in spring-webflux Add FreeMarker macro support in spring-webflux Jun 10, 2019
@sbrannen sbrannen closed this in b58f34d Jun 10, 2019
sbrannen added a commit that referenced this pull request Jun 10, 2019
@sbrannen
Polish FreeMarker macro support in spring-webflux
2f640fe 
See gh-23002
@sbrannen sbrannen mentioned this pull request Jun 10, 2019
Closed
1 task
sbrannen added a commit that referenced this pull request Jun 10, 2019
@sbrannen
Fix documentation for FreeMarker bind macro in spring-webflux
7a87d86 
See gh-23002
@sbrannen
Copy link
Member

This has been merged into master in b58f34d and refined in 2f640fe.

Thanks again for the PR!

@ielatif ielatif deleted the gh-22950 branch June 10, 2019 14:47
@sbrannen sbrannen mentioned this pull request Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M3
Development

Successfully merging this pull request may close these issues.
3 participants
@ielatif @sbrannen @spring-projects-issues