Skip to content

Improve FreeMarker Unit Tests in spring-webflux #23009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ielatif opened this issue May 21, 2019 · 3 comments
Closed

Improve FreeMarker Unit Tests in spring-webflux #23009

ielatif opened this issue May 21, 2019 · 3 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: task A general task

Comments

@ielatif
Copy link
Contributor

ielatif commented May 21, 2019 •
edited
Loading

Affects: 5.1.7

While working on #22950 I noticed that Unit Tests FreeMarkerConfigurerTests and FreeMarkerMacroTests (like those in spring-webmvc) are missing.

Is it a deliberate choice or should we add them?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 21, 2019
@sbrannen
Copy link
Member

I think it's a good idea to have unit tests in place for the Webflux variants as well.

Feel free to submit a PR for that.

@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) status: ideal-for-contribution An issue that a contributor can help us with type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 23, 2019
@ielatif
Copy link
Contributor Author

ielatif commented May 26, 2019

Ok I will submit a PR.

@sbrannen
Copy link
Member

I actually requested the introduction of tests in #23002 (review).

So, please introduce those tests in your existing PR (#23002).

Superseded by #23002.

@sbrannen sbrannen added status: superseded An issue that has been superseded by another and removed status: ideal-for-contribution An issue that a contributor can help us with labels May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbrannen @ielatif @spring-projects-issues