Bugfix for https://jira.springsource.org/browse/SPR-9445 #85
Conversation
|
Hi Oliver, thanks for the submission! I'll take a look at this -- in the meantime, please carefully read the contributor guidelines and make the necessary updates. |
ghost
assigned
| return ExpressionUtils.convert(state.getEvaluationContext(), result, desiredReturnType); | ||
| } | ||
| return (T) result; | ||
| return ExpressionUtils.convertTypedValue(state.getEvaluationContext(), getValueInternal(state), desiredReturnType); |
There was a problem hiding this comment.
all of the removed code will be executed in ExpressionUtils.convertTypedValue(), so there's no need to do it separately here
|
I have added the note on the Individual Contributor License Agreement, however I'm not sure if I should (or if I even can) change the commit message as required be the guidelines. |
The appropriate commit message should probably read as follows:Pass null values through the converter before checking for null in boolean operators OpOr, OpAnd, OperatorNot Since null values might be converted into something meaningful in Issue: SPR-9445 |
|
Thanks, Oliver. |
* pull85: Call ConversionService for null SpEL values Polish whitespace
|
Hi Oliver, I have merged the pull request with some minor tweaks (see commit 759c9b3). Thanks for the contribution! |
This commit makes messageEncoders a required argument for building a client request - those are needed to actually encode the body object as a reactive stream to be written to the HTTP request body. Removed raw types usage in DefaultHttpRequestBuilder. DefaultHttpRequestBuilder now uses a UriTemplateHandler to expand URI templates + variables into a concrete URI. Fixes spring-projects#80, fixes spring-projects#85, fixes spring-projects#86
This commit makes messageEncoders a required argument for building a client request - those are needed to actually encode the body object as a reactive stream to be written to the HTTP request body. Removed raw types usage in DefaultHttpRequestBuilder. DefaultHttpRequestBuilder now uses a UriTemplateHandler to expand URI templates + variables into a concrete URI. Fixes spring-projects#80, fixes spring-projects#85, fixes spring-projects#86
These are the proposed changes to fix the bug SPR-9445
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.
Regards,
Oliver