HttpClientErrorException should provide access to response headers #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
Default HTTP errors from RestTemplate now include the response headers in addition to the response body. In particular, this enables inspection of the Content-Type header allowing manual deserialization of the response body without guessing as to the content type. * introduced HttpStatusCodeException#getResponseHeaders * added constructor with headers param for HttpStatusCodeException, HttpClientErrorException and HttpServerErrorException * preserved exsisting constructor signatures * marked HttpHeaders as Serializable * generated new serialVersionUID where needed Issue: SPR-7938
cbeams
added a commit
that referenced
this pull request
Jun 1, 2012
* SPR-7938: Include response headers in RestTemplate exceptions Polish web.client exceptions and related classes
|
Thanks, Scott. For future reference, please
|
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jun 20, 2016
This commit makes messageEncoders a required argument for building a client request - those are needed to actually encode the body object as a reactive stream to be written to the HTTP request body. Removed raw types usage in DefaultHttpRequestBuilder. DefaultHttpRequestBuilder now uses a UriTemplateHandler to expand URI templates + variables into a concrete URI. Fixes spring-projects#80, fixes spring-projects#85, fixes spring-projects#86
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jul 13, 2016
This commit makes messageEncoders a required argument for building a client request - those are needed to actually encode the body object as a reactive stream to be written to the HTTP request body. Removed raw types usage in DefaultHttpRequestBuilder. DefaultHttpRequestBuilder now uses a UriTemplateHandler to expand URI templates + variables into a concrete URI. Fixes spring-projects#80, fixes spring-projects#85, fixes spring-projects#86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
HttpHeaders getResponseHeaders()to HttpStatusCodeException andpopulating value via DefaultResponseErrorHandler.
Issue: SPR-7938