Skip to content

Collapse ErrorHandler and BatchErrorHandler interface hierarchies into a single interface #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Mar 21, 2018 · 2 comments · Fixed by #1892
Closed

Collapse ErrorHandler and BatchErrorHandler interface hierarchies into a single interface #615

garyrussell opened this issue Mar 21, 2018 · 2 comments · Fixed by #1892
Assignees
@garyrussell
Milestone
2.8.0-M1

Comments

@garyrussell
Copy link
Contributor

No description provided.

@garyrussell garyrussell added this to the 2.2.M1 milestone Mar 21, 2018
@garyrussell garyrussell self-assigned this Mar 21, 2018
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 21, 2018
@garyrussell
spring-projectsGH-614: Fix general consumer error handling
bbe9610 
Fixes spring-projects#614

PR spring-projects#595 added support for calling error handlers for general errors not related
to listener invocation.

However, the wrong `handle()` method was called.

Add a default implementation of the lowest interface method in the hierarchies to
`ErrorHandler` and `BatchErrorHandler` respectively and invoke that so the
right method will always be invoked, regardless of the error handler type.

Also see spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 21, 2018
@garyrussell
spring-projectsGH-614: Fix general consumer error handling
df7fa4b 
Fixes spring-projects#614

PR spring-projects#595 added support for calling error handlers for general errors not related
to listener invocation.

However, the wrong `handle()` method was called.

Add a default implementation of the lowest interface method in the hierarchies to
`ErrorHandler` and `BatchErrorHandler` respectively and invoke that so the
right method will always be invoked, regardless of the error handler type.

Also see spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 21, 2018
@garyrussell
spring-projectsGH-614: Fix general consumer error handling
cb5d546 
Fixes spring-projects#614

PR spring-projects#595 added support for calling error handlers for general errors not related
to listener invocation.

However, the wrong `handle()` method was called.

Add a default implementation of the lowest interface method in the hierarchies to
`ErrorHandler` and `BatchErrorHandler` respectively and invoke that so the
right method will always be invoked, regardless of the error handler type.

Also see spring-projects#615
@garyrussell garyrussell mentioned this issue Mar 21, 2018
Merged
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 21, 2018
@garyrussell
spring-projectsGH-614: Fix general consumer error handling
c76a00a 
Fixes spring-projects#614

PR spring-projects#595 added support for calling error handlers for general errors not related
to listener invocation.

However, the wrong `handle()` method was called.

Add a default implementation of the lowest interface method in the hierarchies to
`ErrorHandler` and `BatchErrorHandler` respectively and invoke that so the
right method will always be invoked, regardless of the error handler type.

Also see spring-projects#615
artembilan pushed a commit that referenced this issue Mar 21, 2018
@garyrussell @artembilan
GH-614: Fix general consumer error handling
b0be198 
Fixes #614

PR #595 added support for calling error handlers for general errors not related
to listener invocation.

However, the wrong `handle()` method was called.

Add a default implementation of the lowest interface method in the hierarchies to
`ErrorHandler` and `BatchErrorHandler` respectively and invoke that so the
right method will always be invoked, regardless of the error handler type.

Also see #615
@tengvig tengvig mentioned this issue May 4, 2018
Closed
@garyrussell
Copy link
Contributor Author

Closing as won't fix.

@garyrussell
Copy link
Contributor Author

Reopening: #1837

@garyrussell garyrussell reopened this Jun 22, 2021
@garyrussell garyrussell mentioned this issue Jun 22, 2021
Merged
@garyrussell garyrussell modified the milestones: Backlog, 3.0.M1 Jun 22, 2021
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 14, 2021
@garyrussell
spring-projectsGH-615: Error Handler Evolution Part 1
d1d7968 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 14, 2021
@garyrussell
spring-projectsGH-615: Error Handler Evolution Part 1
0745f0b 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 14, 2021
@garyrussell
spring-projectsGH-615: Error Handler Evolution Part 1
7bc9958 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 14, 2021
@garyrussell
spring-projectsGH-615: Error Handler Evolution Part 1
b249d9f 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 14, 2021
@garyrussell
spring-projectsGH-615: Error Handler Evolution Part 1
4f9951e 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 14, 2021
@garyrussell
spring-projectsGH-615: Error Handler Evolution Part 1
fe1984b 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See spring-projects#615
@garyrussell garyrussell mentioned this issue Jul 14, 2021
Merged
artembilan pushed a commit that referenced this issue Jul 15, 2021
@garyrussell
GH-615: Error Handler Evolution Part 1
cd661dc 
Flatten `GenericErrorHandler` into a single interface.
Create an adapter for legacy error handlers.

See #615

* Fix since; expand javadocs; improve method names.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 16, 2021
@garyrussell
spring-projectsGH-615: Add CommonLoggingErrorHandler
1178ebe 
See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 16, 2021
@garyrussell
spring-projectsGH-615: Add CommonLoggingErrorHandler
4c180ef 
See spring-projects#615
@garyrussell garyrussell mentioned this issue Jul 16, 2021
Merged
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 16, 2021
@garyrussell
spring-projectsGH-615: Add CommonLoggingErrorHandler
36e2364 
See spring-projects#615
artembilan pushed a commit that referenced this issue Jul 16, 2021
@garyrussell
GH-615: Add CommonLoggingErrorHandler
cf89aee 
See #615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2021
@garyrussell
spring-projectsGH-615: DEH WIP
03dc8c1
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2021
@garyrussell
spring-projectsGH-615: Add DefaultErrorHandler
17ea294 
See spring-projects#615

Replaces legacy `SeekToCurrentErrorHandler` and `RecoveringBatchErrorHandler`.
These were the previous defaults when no transaction manager is present.
They will be deprecated in a future PR.

- refactor common code into superclass/utilities
- copy existing test case classes, changing the error handler types
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2021
@garyrussell
spring-projectsGH-615: Add DefaultErrorHandler
502e08b 
See spring-projects#615

Replaces legacy `SeekToCurrentErrorHandler` and `RecoveringBatchErrorHandler`.
These were the previous defaults when no transaction manager is present.
They will be deprecated in a future PR.

- refactor common code into superclass/utilities
- copy existing test case classes, changing the error handler types
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2021
@garyrussell
spring-projectsGH-615: Add DefaultErrorHandler
8535af3 
See spring-projects#615

Replaces legacy `SeekToCurrentErrorHandler` and `RecoveringBatchErrorHandler`.
These were the previous defaults when no transaction manager is present.
They will be deprecated in a future PR.

- refactor common code into superclass/utilities
- copy existing test case classes, changing the error handler types
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 19, 2021
@garyrussell
spring-projectsGH-615: Add DefaultErrorHandler
bcbf9e4 
See spring-projects#615

Replaces legacy `SeekToCurrentErrorHandler` and `RecoveringBatchErrorHandler`.
These were the previous defaults when no transaction manager is present.
They will be deprecated in a future PR.

- refactor common code into superclass/utilities
- copy existing test case classes, changing the error handler types
@garyrussell garyrussell mentioned this issue Jul 19, 2021
Merged
artembilan pushed a commit that referenced this issue Jul 20, 2021
@garyrussell
GH-615: Add DefaultErrorHandler
3b06529 
* GH-615: Add DefaultErrorHandler

See #615

Replaces legacy `SeekToCurrentErrorHandler` and `RecoveringBatchErrorHandler`.
These were the previous defaults when no transaction manager is present.
They will be deprecated in a future PR.

- refactor common code into superclass/utilities
- copy existing test case classes, changing the error handler types

* Add CommonDelegatingErrorHandler
garyrussell added a commit that referenced this issue Jul 21, 2021
@garyrussell
GH-615: Fix new Sonar Issue
8fa4c60
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 28, 2021
@garyrussell
spring-projectsGH-615: More CommonErrorHandlers
20994c2 
See spring-projects#615

- CommonContainerStoppingErrorHandler
- CommonMixedErrorHandler
@garyrussell garyrussell mentioned this issue Jul 28, 2021
Merged
artembilan pushed a commit that referenced this issue Jul 28, 2021
@garyrussell @artembilan
GH-615: More CommonErrorHandlers
50196bf 
See #615

- CommonContainerStoppingErrorHandler
- CommonMixedErrorHandler
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 29, 2021
@garyrussell
spring-projectsGH-615: Complete CommonErrorHandler Work
989acf6 
Resolves spring-projects#615

- Deprecate remaining legacy error handlers
- Fix `DefaultErrorHandler` for remaining records and delivery header
- Docs
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 29, 2021
@garyrussell
spring-projectsGH-615: Complete CommonErrorHandler Work
b2ffc44 
Resolves spring-projects#615

- Deprecate remaining legacy error handlers
- Fix `DefaultErrorHandler` for remaining records and delivery header
- Docs
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 29, 2021
@garyrussell
spring-projectsGH-615: Complete CommonErrorHandler Work
ebdf4a8 
Resolves spring-projects#615

- Deprecate remaining legacy error handlers
- Fix `DefaultErrorHandler` for remaining records and delivery header
- Docs
@garyrussell garyrussell mentioned this issue Jul 29, 2021
Merged
artembilan pushed a commit that referenced this issue Jul 29, 2021
@garyrussell @artembilan
GH-615: Complete CommonErrorHandler Work
9ad308d 
Resolves #615

- Deprecate remaining legacy error handlers
- Fix `DefaultErrorHandler` for remaining records and delivery header
- Docs
@garyrussell garyrussell changed the title Collapse ErrorHandler and BatchErrorHandler interface hierarchies into a single interface for each Collapse ErrorHandler and BatchErrorHandler interface hierarchies into a single interface Mar 3, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 3, 2022
@garyrussell
spring-projectsGH-615: Docs - Migrating Legacy Error Handlers
0a3925a 
See spring-projects#615
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 3, 2022
@garyrussell
spring-projectsGH-615: Docs - Migrating Legacy Error Handlers
9876ae6 
See spring-projects#615
@garyrussell garyrussell mentioned this issue Mar 3, 2022
Merged
artembilan pushed a commit that referenced this issue Mar 3, 2022
@garyrussell @artembilan
GH-615: Docs - Migrating Legacy Error Handlers
9741d28 
See #615
artembilan pushed a commit that referenced this issue Mar 3, 2022
@garyrussell @artembilan
GH-615: Docs - Migrating Legacy Error Handlers
6b60316 
See #615

# Conflicts:
#	spring-kafka-docs/src/main/asciidoc/kafka.adoc
@garyrussell garyrussell modified the milestones: 3.0 Backlog, 2.8.0-M1 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
None yet
Projects
None yet
Milestone
2.8.0-M1
Development

Successfully merging a pull request may close this issue.

GH-615: Complete CommonErrorHandler Work garyrussell/spring-kafka
1 participant
@garyrussell