GH-615: Error Handler Evolution Part 1 #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flatten `GenericErrorHandler` into a single interface. Create an adapter for legacy error handlers. See spring-projects#615
artembilan
requested changes
Jul 15, 2021
| * sub-interfaces. | ||
| * | ||
| * @author Gary Russell | ||
| * @since 2.7.4 |
There was a problem hiding this comment.
I'm confused a little bit: the issue says 3.0 Backlog, but looks like you even would like to back-port it to 2.7.x.
Although I may see your point: you want to introduce it now to deprecate and remove those gradually in the future versions.
What is you thought on the matter, please?
There was a problem hiding this comment.
Oops - sorry; I started this work a few weeks ago before I decided to make main 2.8.x.
I also want to make a few more changes to ease migration of the old error handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten
GenericErrorHandlerinto a single interface.Create an adapter for legacy error handlers.
See #615