Skip to content

GH-2252: Keep offset metadata in case of batch reprocessing #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

GH-2252: Keep offset metadata in case of batch reprocessing #2253

merged 3 commits into from
May 9, 2022

Conversation

frosiere
Copy link
Contributor

@frosiere frosiere commented May 3, 2022 •
edited
Loading

Remarks:

  • Every OffsetAndMetadata are now created using the provider if available.
  • Listener info has been added to the MessageListener container interface.
  • Code related to the provider has been refactored and simplified.
  • Javadoc has been reviewed.
  • Updated the CommitProperties documentation

Closes #2252

artembilan
artembilan requested changes May 4, 2022
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add your name to the @author list of all the affected classes.
When it missed yet, of course.

Otherwise this is OK with me even if those minor concerns.

Thank you!

garyrussell
garyrussell suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit.

@frosiere frosiere requested a review from garyrussell May 5, 2022 19:40
@frosiere
Copy link
Contributor Author

frosiere commented May 6, 2022

Any review remarks have been applied. If something else is required, please let me know.

@garyrussell garyrussell merged commit f94620a into spring-projects:main May 9, 2022
garyrussell pushed a commit that referenced this pull request May 9, 2022
@frosiere @garyrussell
GH-2252: Keep offset metadata in case of batch reprocessing (#2253)
968df68 
* GH-2252: Keep offset metadata in case of batch reprocessing

* GH-2252: Applied code review

* GH-2252: Added missing static keyword
garyrussell pushed a commit that referenced this pull request May 9, 2022
@frosiere @garyrussell
GH-2252: Keep offset metadata in case of batch reprocessing (#2253)
6e92b7f 
* GH-2252: Keep offset metadata in case of batch reprocessing

* GH-2252: Applied code review

* GH-2252: Added missing static keyword
@garyrussell
Copy link
Contributor

...and cherry-picked to 2.9.x, 2.8.x after resolving conflicts.

@garyrussell
Copy link
Contributor

Many thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyrussell garyrussell garyrussell approved these changes

@artembilan artembilan artembilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offset metadata should not be lost in case of batch reprocessing
3 participants
@frosiere @garyrussell @artembilan