Skip to content

SecurityContextCallableProcessingInterceptor securityContext field should volatile #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lmagyar89 opened this issue Nov 26, 2018 · 1 comment
Closed

SecurityContextCallableProcessingInterceptor securityContext field should volatile #6143

lmagyar89 opened this issue Nov 26, 2018 · 1 comment

Comments

@lmagyar89
Copy link
Contributor

Summary

Within class org.springframework.security.web.context.request.async.SecurityContextCallableProcessingInterceptor field securityContext should volatile.

Actual Behavior

Above mentioned field is regular field.

Expected Behavior

Since beforeConcurrentHandling method and preProcess method called on different threads to make sure there is no visibility issue volatile modifier should used.

Configuration

Version

All version affected.

Sample
@lmagyar89
Copy link
Contributor Author

My PR:
#6144

@rwinch rwinch closed this as completed in 3c35f4c Dec 3, 2018
rwinch pushed a commit that referenced this issue Dec 3, 2018
@lmagyar89 @rwinch
SecurityContextCallableProcessingInterceptor thread visibility fix
b7cebee 
Within class SecurityContextCallableProcessingInterceptor field securityContext should volatile.

Fixes gh-6143
rwinch pushed a commit that referenced this issue Dec 3, 2018
@lmagyar89 @rwinch
SecurityContextCallableProcessingInterceptor thread visibility fix
d8f039b 
Within class SecurityContextCallableProcessingInterceptor field securityContext should volatile.

Fixes gh-6143
rwinch pushed a commit that referenced this issue Dec 3, 2018
@lmagyar89 @rwinch
SecurityContextCallableProcessingInterceptor thread visibility fix
fd31e52 
Within class SecurityContextCallableProcessingInterceptor field securityContext should volatile.

Fixes gh-6143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmagyar89