SecurityContextCallableProcessingInterceptor thread visibility fix #6144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @lmagyar89! Can you please adjust the commit message to conform with Spring Security's conventions. Specifically, please provide a meaningful but concise subject (first line), any additional details as the body, and Fixes: gh-6144 at the end. |
Within class SecurityContextCallableProcessingInterceptor field securityContext should volatile. Fixes gh-6143
lmagyar89
changed the title
|
@rwinch should I need anything else to add/modify? |
This was referenced Dec 3, 2018
|
Thanks for the PR @lmagyar89! This is now merged into master and backported to 5.1.x 5.0.x and 4.2.x via #6216 #6217 #6218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add volatile to make sure correct thread visibility