Merge main into ray/ui-update #724
Conversation
While most workflow use cases is likely to be inside an Activity and can specify renderings to be updated while in the Lifecycle.State.STARTED state, there are certain use cases where we want the workflow to depend on the application's lifecycle (using ProcessLifecycleOwner.) which will not work when calling repeatOnLifecycle with Lifecycle.State.STARTED as this state event is tied to Activities.
…ayout Allow repeatOnLifecycle state to be configurable.
Use default in the existing Poetry apps but specify simulated config for Performance-Poetry.
699: Add simulated performance config to Poetry
Refactor Perf Poetry to add Related Benchmarks
Update AGP versions, Gradle Versions, and OptIn Notation
`ViewStateCache` was `Parcelable`, in an attempt to simplify `View.onSaveInstanceState()` chores for client container views. That became a source of memory leaks once we added a `WorkflowSavedStateRegistryAggregator` to it, so we've dialed back the convenience. `ViewStateCache` now offers `save(): Saved` and `restore(saved: Saved)`, where `Saved` is a simple `Parcelable`. Client views are responsible for managing their own subclasses of `View.BaseSavedState`, which is sad but not terribly unusual.
Exclude Benchmarks for connectedCheck verification instructions
Fixes memory leak in ViewStateCache.
Bump okio to 3.0.0
Bump tutorials to 1.7.0
* origin/main: Bump tutorials to 1.7.0 Bump okio to 3.0.0 Finish releasing v1.7.0 Releasing v1.7.0 Fixes a typo in step 1 of RELEASING.md Exclude Benchmarks for connectedCheck verification instructions Fixes memory leak in ViewStateCache. Update AGP versions and OptIn Notation Refactor Perf Poetry to add Related Benchmarks 699: Add simulated performance config to Poetry Allow repeatOnLifecycle state to be configurable.
| import kotlin.reflect.KClass | ||
|
|
||
| @OptIn(WorkflowUiExperimentalApi::class) | ||
| object LoaderSpinner : AndroidOverlay<LoaderSpinner> { |
There was a problem hiding this comment.
@steve-the-edwards This replaces LoaderContainer. I'm not thrilled that it requires the author to instantiate the Dialog themselves, where with the old one they could just focus on building a view as usual.
I'm inclined to follow up by adding a vanilla Overlay wrapper type that makes any arbitrary screen a full bleed dialog, but that's too much for a merge PR.
Oops, I did, crashes on navigation. Following up… |
|
Not sure what's going on. |
|
Oops: |
|
Fixed benchmark poetry. Its spinner is badly sized, another reason to follow up with the Overlay work suggested above. Chatted with Steve, will merge this as is in the meantime. |
rjrjr
force-pushed
the
ray/catchup-1.7.0
branch
from
03181e6 to
5e72bed
Compare
This was mostly a mechanical merge except for the poetry benchmark app. @steve-the-edwards, can you confirm I didn't break that? Also curious about your and @RBusarow's reaction to the conversion of
MayBeLoadingScreento atypealias, and our ability to delete theLoadingContainerView subclass entirely.Bump tutorials to 1.7.0
Bump okio to 3.0.0
Finish releasing v1.7.0
Releasing v1.7.0
Fixes a typo in step 1 of RELEASING.md
Exclude Benchmarks for connectedCheck verification instructions
Fixes memory leak in ViewStateCache.
Update AGP versions and OptIn Notation
Refactor Perf Poetry to add Related Benchmarks
699: Add simulated performance config to Poetry
Allow repeatOnLifecycle state to be configurable.