[feat]: add primary associated types to Workflow protocol
#181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
commented
Jan 19, 2023
Workflow/Sources/Workflow.swift
Outdated
| /// Defines the state that is managed by this workflow. | ||
| associatedtype State | ||
| #if swift(>=5.7) | ||
| public protocol Workflow<Rendering, Output>: AnyWorkflowConvertible { |
There was a problem hiding this comment.
for the time being, decided to just make this change on Workflow itself, as i believe that is by far the most useful change. if there are other compelling additions we could add them in the future.
with this change, we can now leverage the following forms of type erasure:
func boxedAnyWorkflow() -> AnyWorkflow<Rendering, Output> {
MyWorkflow().asAnyWorkflow()
}
func existentialAnyWorkflow() -> any Workflow<Rendering, Output> {
if someCondition {
return MyWorkflow()
} else {
return MyOtherWorkflow()
}
}
func opaqueWorkflow() -> some Workflow<Rendering, Output> {
MyWorkflow()
}
jamieQ
force-pushed
the
jquadri/add-pats
branch
from
bbe8b14 to
6de601f
Compare
jamieQ
added a commit
that referenced
this pull request
Feb 6, 2023
* main: [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185) Bump activesupport from 6.1.4.4 to 6.1.7.1 (#183) [feat]: add primary associated types to `Workflow` protocol (#181) [chore]: update swiftformat ifdef indent rule to no-indent (#182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
RenderingandOutputas the primary associated types of theWorkflowprotocolChecklist