[chore]: bump minimum deployment & swift versions #186
Conversation
|
You could probably follow this up with removing the @Availability on the iOS 13+ code. |
There was a problem hiding this comment.
note: this change will require a major version bump for the next release that includes it
Would you re-adjust things such that concurrency's version == workflow again?
Also, have you considered throwing more stuff in version.rb for maintenance? Eg the target OSes/swift version
yep! that's the plan anyway. also have some additional primary associated types to add
that's a good suggestion – i'll look into it! |
Market uses that pattern if you want inspiration |
jamieQ
force-pushed
the
jquadri/bump-deploy-swift-versions
branch
from
62d94ba to
01e4289
Compare
| s.swift_versions = ['5.0'] | ||
| s.ios.deployment_target = '11.0' | ||
| s.swift_versions = [WORKFLOW_SWIFT_VERSION] | ||
| s.ios.deployment_target = WORKFLOW_IOS_DEPLOYMENT_TARGET |
There was a problem hiding this comment.
I love this change instead of repeating the value everywhere 👍
* main: [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185) Bump activesupport from 6.1.4.4 to 6.1.7.1 (#183) [feat]: add primary associated types to `Workflow` protocol (#181) [chore]: update swiftformat ifdef indent rule to no-indent (#182)
…ow-workflow-conformance * origin/main: Expose AnyScreen.wrappedScreen for inspection (#193) Improve introspection for SignalProducerWorkflow actions (#192) [release]: bump version to 2.2.0 & remove separate concurrency version (#191) [feat]: add runtime observation API (#168) [chore]: refactor some internal actions to use existential any (#190) [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185)
Issue
Description
ENABLE_TESTING_SEARCH_PATHSto WorkflowTesting podspec to resolve search path issues induced by deployment target changeVERSIONfile in favor ofversion.rb, and standardize version referencesnote: this change will require a major version bump for the next release that includes it
Checklist